changeset 2670:84a10fce92a1 trunk

[svn] - playlist_set_info() does not change the playlist and shouldn't block
author nenolod
date Tue, 10 Apr 2007 11:25:39 -0700
parents 0b4949cad842
children e9b379528fbc
files ChangeLog src/audacious/build_stamp.c src/audacious/playlist.c
diffstat 3 files changed, 10 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Apr 10 11:20:21 2007 -0700
+++ b/ChangeLog	Tue Apr 10 11:25:39 2007 -0700
@@ -1,3 +1,12 @@
+2007-04-10 18:20:21 +0000  William Pitcock <nenolod@sacredspiral.co.uk>
+  revision [4364]
+  - tuple operations do not change the structure of the playlist and 
+    shouldn't block via mutexlock accordingly
+  
+  trunk/src/audacious/playlist.c |   11 -----------
+  1 file changed, 11 deletions(-)
+
+
 2007-04-10 18:12:56 +0000  William Pitcock <nenolod@sacredspiral.co.uk>
   revision [4362]
   - unlock many playlist operations that do not really need locking
--- a/src/audacious/build_stamp.c	Tue Apr 10 11:20:21 2007 -0700
+++ b/src/audacious/build_stamp.c	Tue Apr 10 11:25:39 2007 -0700
@@ -1,2 +1,2 @@
 #include <glib.h>
-const gchar *svn_stamp = "20070410-4362";
+const gchar *svn_stamp = "20070410-4364";
--- a/src/audacious/playlist.c	Tue Apr 10 11:20:21 2007 -0700
+++ b/src/audacious/playlist.c	Tue Apr 10 11:25:39 2007 -0700
@@ -1047,8 +1047,6 @@
 {
     Playlist *playlist = playlist_get_active();
 
-    PLAYLIST_LOCK(playlist->mutex);
-
     g_return_if_fail(playlist != NULL);
 
     if (playlist->position) {
@@ -1065,8 +1063,6 @@
         }
     }
 
-    PLAYLIST_UNLOCK(playlist->mutex);
-
     playlist_recalc_total_time(playlist);
 
     mainwin_set_song_info(rate, freq, nch);
@@ -1079,8 +1075,6 @@
 playlist_set_info(Playlist * playlist, const gchar * title, gint length, gint rate,
                   gint freq, gint nch)
 {
-    PLAYLIST_LOCK(playlist->mutex);
-
     g_return_if_fail(playlist != NULL);
 
     if (playlist->position) {
@@ -1089,8 +1083,6 @@
         playlist->position->length = length;
     }
 
-    PLAYLIST_UNLOCK(playlist->mutex);
-
     playlist_recalc_total_time(playlist);
 
     mainwin_set_song_info(rate, freq, nch);