changeset 2063:a3ad15fb0f34 trunk

[svn] - playlist_scan_thread_is_going should not be TRUE if the playlist is not visible, otherwise spinlocking may occur if on demand metadata reading is enabled.
author nenolod
date Wed, 06 Dec 2006 03:41:04 -0800
parents 409df027cc31
children 230e36118438
files ChangeLog audacious/playlist.c
diffstat 2 files changed, 18 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Dec 05 00:31:38 2006 -0800
+++ b/ChangeLog	Wed Dec 06 03:41:04 2006 -0800
@@ -1,3 +1,13 @@
+2006-12-05 08:31:38 +0000  William Pitcock <nenolod@nenolod.net>
+  revision [3127]
+  - rewrite input_check_file()
+  - make similar functions use input_check_file() instead of probing by 
+    hand
+  
+  trunk/audacious/input.c |  109 ++++++++++++++++++------------------------------
+  1 file changed, 43 insertions(+), 66 deletions(-)
+
+
 2006-12-05 03:43:36 +0000  William Pitcock <nenolod@nenolod.net>
   revision [3125]
   - mainwinEjectY's default value should be 89, not 88.
--- a/audacious/playlist.c	Tue Dec 05 00:31:38 2006 -0800
+++ b/audacious/playlist.c	Wed Dec 06 03:41:04 2006 -0800
@@ -2299,6 +2299,14 @@
                 PLAYLIST_UNLOCK();
             }
         } // on_demand
+        else if (cfg.get_info_on_demand && 
+			(!cfg.playlist_visible || cfg.playlist_shaded
+                	 || !cfg.use_pl_metadata))
+        {
+            g_mutex_lock(mutex_scan);
+            playlist_get_info_scan_active = FALSE;
+            g_mutex_unlock(mutex_scan);
+        }
 
         if (update_playlistwin) {
             playlistwin_update_list();