Mercurial > audlegacy

changeset 4518:f2271d78e07e

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Handling of remote DBus PlaylistAdd method was incorrect, causing a segfault. Dbus marshaller does not send a GList of strings of filenames to be added to audacious_rc_playlist_add(), but the list element data. Fixed.
author Matti Hamalainen <ccr@tnsp.org>
date Sun, 27 Apr 2008 03:24:07 +0300
parents 6e412073cf28
children fcd7a800dcd7
files src/audacious/dbus.c
diffstat 1 files changed, 1 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/src/audacious/dbus.c	Wed Apr 23 22:20:35 2008 +0200
+++ b/src/audacious/dbus.c	Sun Apr 27 03:24:07 2008 +0300
@@ -945,13 +945,8 @@
     return TRUE;
 }
 
-static void call_playlist_add_url(GList *list, gpointer *data) {
-        playlist_add_url(playlist_get_active(), list->data);
-}
-
 gboolean audacious_rc_playlist_add(RemoteObject *obj, gpointer list, GError **error) {
-    g_list_foreach((GList *)list, (GFunc)call_playlist_add_url, NULL);
-    return TRUE;
+    return playlist_add_url(playlist_get_active(), (gchar *) list) > 0;
 }
 
 gboolean audacious_rc_playlist_enqueue_to_temp(RemoteObject *obj, gchar *url, GError **error) {