Mercurial > emacs
changeset 111044:0f9cd375624d
Don't allow functions that display messages in unsafep.
* emacs-lisp/unsafep.el: Don't mark functions that display
messages as safe. Suggested by Johan Bockgrd.
| author | Chong Yidong <cyd@stupidchicken.com> |
|---|---|
| date | Mon, 18 Oct 2010 13:28:20 -0400 |
| parents | 502ba24bf657 |
| children | fd1924053d81 |
| files | lisp/ChangeLog lisp/emacs-lisp/unsafep.el |
| diffstat | 2 files changed, 8 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/ChangeLog Mon Oct 18 08:23:41 2010 -0400 +++ b/lisp/ChangeLog Mon Oct 18 13:28:20 2010 -0400 @@ -1,3 +1,8 @@ +2010-10-18 Chong Yidong <cyd@stupidchicken.com> + + * emacs-lisp/unsafep.el: Don't mark functions that display + messages as safe. Suggested by Johan Bockgård. + 2010-10-17 Stefan Monnier <monnier@iro.umontreal.ca> * minibuffer.el (completion--replace): Move point where it belongs
--- a/lisp/emacs-lisp/unsafep.el Mon Oct 18 08:23:41 2010 -0400 +++ b/lisp/emacs-lisp/unsafep.el Mon Oct 18 13:28:20 2010 -0400 @@ -101,15 +101,13 @@ (dolist (x '(;;Special forms and catch if or prog1 prog2 progn while unwind-protect ;;Safe subrs that have some side-effects - ding error message minibuffer-message random read-minibuffer - signal sleep-for string-match throw y-or-n-p yes-or-no-p + ding error random signal sleep-for string-match throw ;;Defsubst functions from subr.el caar cadr cdar cddr ;;Macros from subr.el - save-match-data unless when with-temp-message + save-match-data unless when ;;Functions from subr.el that have side effects - read-passwd split-string replace-regexp-in-string - play-sound-file)) + split-string replace-regexp-in-string play-sound-file)) (put x 'safe-function t)) ;;;###autoload