changeset 87441:350032476821

(thumbs-call-convert): Use call-process directly with thumbs-conversion-program instead of through shell-file-name for better error reporting when program is missing.
author Nick Roberts <nickrob@snap.net.nz>
date Fri, 28 Dec 2007 08:09:57 +0000
parents 487e9c17a9ec
children c5df210848ca
files lisp/thumbs.el
diffstat 1 files changed, 6 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/thumbs.el	Fri Dec 28 08:08:34 2007 +0000
+++ b/lisp/thumbs.el	Fri Dec 28 08:09:57 2007 +0000
@@ -248,15 +248,12 @@
 OUTPUT-FORMAT is the file format to output (default is jpeg),
 ACTION-PREFIX is the symbol to place before the ACTION command
               (defaults to '-' but can sometimes be '+')."
-  (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\""
-			 thumbs-conversion-program
-			 (or action-prefix "-")
-			 action
-			 (or arg "")
-			 filein
-			 (or output-format "jpeg")
-			 fileout)))
-    (call-process shell-file-name nil nil nil shell-command-switch command)))
+  (call-process thumbs-conversion-program nil nil nil
+		(or action-prefix "-")
+		action
+		(or arg "")
+		filein
+		(format "%s:%s"	(or output-format "jpeg") fileout)))
 
 (defun thumbs-new-image-size (s increment)
   "New image (a cons of width x height)."