changeset 82422:77d2d5f85dbc

(compilation-get-file-structure): Make use of the directory part when checking for an existing entry, to handle files with same basename in different directories.
author Glenn Morris <rgm@gnu.org>
date Fri, 17 Aug 2007 07:17:13 +0000
parents 84edadc1cf67
children 917e5775e0f3
files lisp/progmodes/compile.el
diffstat 1 files changed, 7 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/progmodes/compile.el	Fri Aug 17 04:30:09 2007 +0000
+++ b/lisp/progmodes/compile.el	Fri Aug 17 07:17:13 2007 +0000
@@ -1972,7 +1972,13 @@
 	;; Store it for the possibly unnormalized name
 	(puthash file
 		 ;; Retrieve or create file-structure for normalized name
-		 (or (gethash (list filename) compilation-locs)
+		 ;; The gethash used to not use spec-directory, but
+		 ;; this leads to errors when files in different
+		 ;; directories have the same name:
+		 ;; http://lists.gnu.org/archive/html/emacs-devel/2007-08/msg00463.html
+		 (or (gethash (cons filename spec-directory) compilation-locs)
+		     ;; TODO should this, without spec-directory, be
+		     ;; done at all?
 		     (puthash (list filename)
 			      (list (list filename spec-directory) fmt)
 			      compilation-locs))