Mercurial > emacs
changeset 109028:9f55c53fc33a
Avoid recentering when lines differ in their height.
xdisp.c (try_scrolling): When scroll-conservatively is set to
most-positive-fixnum, be extra accurate when scrolling window
start, to avoid missing the cursor line.
| author | Eli Zaretskii <eliz@gnu.org> |
|---|---|
| date | Sun, 20 Jun 2010 21:04:30 +0300 |
| parents | 858e3e43cfd5 |
| children | 85a8c1358bb7 9557b86a556a |
| files | src/ChangeLog src/xdisp.c |
| diffstat | 2 files changed, 26 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ChangeLog Sun Jun 20 00:55:14 2010 -0400 +++ b/src/ChangeLog Sun Jun 20 21:04:30 2010 +0300 @@ -1,3 +1,9 @@ +2010-06-20 Eli Zaretskii <eliz@gnu.org> + + * xdisp.c (try_scrolling): When scroll-conservatively is set to + most-positive-fixnum, be extra accurate when scrolling window + start, to avoid missing the cursor line. + 2010-06-19 Eli Zaretskii <eliz@gnu.org> * xdisp.c (try_scrolling): Compute the limit for searching point
--- a/src/xdisp.c Sun Jun 20 00:55:14 2010 -0400 +++ b/src/xdisp.c Sun Jun 20 21:04:30 2010 +0300 @@ -13486,7 +13486,26 @@ return SCROLLING_FAILED; start_display (&it, w, startp); - move_it_vertically (&it, amount_to_scroll); + if (scroll_max < INT_MAX) + move_it_vertically (&it, amount_to_scroll); + else + { + /* Extra precision for users who set scroll-conservatively + to most-positive-fixnum: make sure the amount we scroll + the window start is never less than amount_to_scroll, + which was computed as distance from window bottom to + point. This matters when lines at window top and lines + below window bottom have different height. */ + struct it it1 = it; + /* We use a temporary it1 because line_bottom_y can modify + its argument, if it moves one line down; see there. */ + int start_y = line_bottom_y (&it1); + + do { + move_it_by_lines (&it, 1, 1); + it1 = it; + } while (line_bottom_y (&it1) - start_y < amount_to_scroll); + } /* If STARTP is unchanged, move it down another screen line. */ if (CHARPOS (it.current.pos) == CHARPOS (startp))