changeset 68189:bb73cb6860d2

(require): Added Satyaki's comment regarding what needs to happen to remove this defadvice which caused a little discussion on emacs-devel today (see Subject: mh-e/mh-acros.el advices `require' incorrectly).
author Bill Wohler <wohler@newt.com>
date Sat, 14 Jan 2006 02:10:11 +0000
parents dcf226991252
children fa9bfcab4414
files lisp/mh-e/ChangeLog lisp/mh-e/mh-acros.el
diffstat 2 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/lisp/mh-e/ChangeLog	Sat Jan 14 02:05:23 2006 +0000
+++ b/lisp/mh-e/ChangeLog	Sat Jan 14 02:10:11 2006 +0000
@@ -1,5 +1,10 @@
 2006-01-13  Bill Wohler  <wohler@newt.com>
 
+	* mh-acros.el (require): Added Satyaki's comment regarding what
+	needs to happen to remove this defadvice which caused a little
+	discussion on emacs-devel today (see Subject: mh-e/mh-acros.el
+	advices `require' incorrectly).
+
 	* mh-search.el (mh-index-next-result-function): Add format to
 	docstring.
 	(mh-mairix-next-result): Use nil instead of () which doesn't stand
--- a/lisp/mh-e/mh-acros.el	Sat Jan 14 02:05:23 2006 +0000
+++ b/lisp/mh-e/mh-acros.el	Sat Jan 14 02:10:11 2006 +0000
@@ -150,6 +150,9 @@
                           (list 'nth ,x z)))
        (quote ,struct-name))))
 
+;; A better solution would be to use Stefan's change in bytecomp.el.
+;; If it were checked in, we can drop the advice to require and it
+;; will make things nicer elsewhere too.
 (defadvice require (around mh-prefer-el activate)
   "Modify `require' to load uncompiled MH-E files."
   (or (featurep (ad-get-arg 0))