Mercurial > emacs
changeset 111929:c8a80ac35b9a
Fix bug #1077 with popping new frames from a minibuffer-only frame.
Do NOT merge with trunk!
menu-bar.el (menu-bar-frame-for-menubar, menu-bar-positive-p): New functions.
(menu-bar-showhide-menu) <menu-bar-mode, showhide-tool-bar>: Use
them instead of `nil' and `>', respectively.
| author | Eli Zaretskii <eliz@gnu.org> |
|---|---|
| date | Thu, 09 Dec 2010 20:53:17 +0200 |
| parents | 89658283a80c |
| children | 9dd98ad8946c |
| files | lisp/ChangeLog lisp/menu-bar.el |
| diffstat | 2 files changed, 26 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/lisp/ChangeLog Wed Dec 08 17:50:08 2010 -0800 +++ b/lisp/ChangeLog Thu Dec 09 20:53:17 2010 +0200 @@ -1,3 +1,10 @@ +2010-12-09 Eli Zaretskii <eliz@gnu.org> + + * menu-bar.el (menu-bar-frame-for-menubar, menu-bar-positive-p): + New functions. + (menu-bar-showhide-menu) <menu-bar-mode, showhide-tool-bar>: Use + them instead of `nil' and `>', respectively. (Bug#1077) + 2010-12-09 Stephen Berman <stephen.berman@gmx.net> * calendar/diary-lib.el (diary-list-sexp-entries):
--- a/lisp/menu-bar.el Wed Dec 08 17:50:08 2010 -0800 +++ b/lisp/menu-bar.el Thu Dec 09 20:53:17 2010 +0200 @@ -980,16 +980,33 @@ :visible (and (display-graphic-p) (fboundp 'x-show-tip)) :button (:toggle . tooltip-mode))) +(defun menu-bar-frame-for-menubar () + "Return the frame suitable for updating the menu bar." + (or (and (framep menu-updating-frame) + menu-updating-frame) + (selected-frame))) + +(defun menu-bar-positive-p (val) + "Return non-nil iff VAL is a positive number." + (and (numberp val) + (> val 0))) + (define-key menu-bar-showhide-menu [menu-bar-mode] `(menu-item ,(purecopy "Menu-bar") toggle-menu-bar-mode-from-frame :help ,(purecopy "Turn menu-bar on/off") - :button (:toggle . (> (frame-parameter nil 'menu-bar-lines) 0)))) + :button + (:toggle . (menu-bar-positive-p + (frame-parameter (menu-bar-frame-for-menubar) + 'menu-bar-lines))))) (define-key menu-bar-showhide-menu [showhide-tool-bar] `(menu-item ,(purecopy "Tool-bar") toggle-tool-bar-mode-from-frame :help ,(purecopy "Turn tool-bar on/off") :visible (display-graphic-p) - :button (:toggle . (> (frame-parameter nil 'tool-bar-lines) 0)))) + :button + (:toggle . (menu-bar-positive-p + (frame-parameter (menu-bar-frame-for-menubar) + 'tool-bar-lines))))) (define-key menu-bar-options-menu [showhide] `(menu-item ,(purecopy "Show/Hide") ,menu-bar-showhide-menu))