Mercurial > emacs

--- a/lisp/ChangeLog	Wed Feb 03 21:02:56 2010 -0800
+++ b/lisp/ChangeLog	Wed Feb 03 21:05:37 2010 -0800
@@ -1,5 +1,7 @@
 2010-02-04  Glenn Morris  <rgm@gnu.org>

+	* mail/mail-utils.el (mail-unquote-printable-region): Doc fix.
+
 	* simple.el (visual-line-mode): Capitalize lighter.

 2010-02-03  John Wiegley  <jwiegley@gmail.com>
--- a/lisp/mail/mail-utils.el	Wed Feb 03 21:02:56 2010 -0800
+++ b/lisp/mail/mail-utils.el	Wed Feb 03 21:05:37 2010 -0800
@@ -123,13 +123,16 @@
 	(setq i (match-end 0)))
       (apply 'concat (nreverse (cons (substring string i) strings))))))

+;; FIXME Gnus for some reason has `quoted-printable-decode-region' in qp.el.
 ;;;###autoload
 (defun mail-unquote-printable-region (beg end &optional wrapper noerror
 					  unibyte)
   "Undo the \"quoted printable\" encoding in buffer from BEG to END.
 If the optional argument WRAPPER is non-nil,
 we expect to find and remove the wrapper characters =?ISO-8859-1?Q?....?=.
-If NOERROR is non-nil, return t if successful.
+On encountering malformed quoted-printable text, exits with an error,
+unless NOERROR is non-nil, in which case it continues, and returns nil
+when finished.  Returns non-nil on successful completion.
 If UNIBYTE is non-nil, insert converted characters as unibyte.
 That is useful if you are going to character code decoding afterward,
 as Rmail does."
@@ -246,6 +249,10 @@
   "Prune addresses from DESTINATIONS, a list of recipient addresses.
 All addresses matching `rmail-dont-reply-to-names' are removed from
 the comma-separated list.  The pruned list is returned."
+  ;; FIXME this (setting a user option the first time a command is used)
+  ;; is somewhat strange.  Normally one would never set the option,
+  ;; but instead fall back to the default so long as it was nil.
+  ;; Or just set the default directly in the defcustom.
   (if (null rmail-dont-reply-to-names)
       (setq rmail-dont-reply-to-names
 	    (concat (if rmail-default-dont-reply-to-names