Mercurial > geeqie.yaz
annotate CODING @ 565:85b9cec260bc
Fix a bug occuring when using certain actions on a collection
item which is not in the selection.
Triggering it will either result in an assertion failure or a
segfault.
To reproduce:
- open a collection
- right-click on a non-selected image
- select Delete... menu entry (or Copy, Move, Rename, Properties...)
It results in the best case:
** ERROR **: file filelist.c: line 905 (file_data_ref): assertion failed: (fd->magick == 0x12345678)
or a pure segfault due to corrupted data.
collection_table_popup_file_list() has to return a list of filedata *
not a list of gchar *.
author | zas_ |
---|---|
date | Sat, 03 May 2008 16:58:17 +0000 |
parents | 86f4c42afeab |
children | f31ae0d9e163 |
rev | line source |
---|---|
524 | 1 Please keep the general coding style of Geeqie: |
2 | |
3 Space after if, while and for: | |
4 | |
5 while (...) | |
6 for (...) | |
7 if (...) | |
8 | |
9 Indentation of {}: | |
10 | |
11 while (...) | |
12 { | |
13 ... | |
14 } | |
15 | |
16 if (...) | |
17 { | |
18 ... | |
19 } | |
20 else | |
21 { | |
22 ... | |
23 } | |
24 | |
25 Spaces around operators: | |
26 | |
27 i = 2; | |
28 | |
29 Space after comma: | |
30 func(a, b, c); | |
31 | |
32 Use glib functions when possible (ie. g_ascii_isspace() instead of isspace()). | |
33 Please use glib types when possible (ie. gint and gchar instead of int and char) | |
34 . | |
35 | |
36 Check twice the indentation and spurious whitespaces. | |
37 | |
525 | 38 Try to use explicit variable and function names |