Mercurial > geeqie.yaz
view CODING @ 565:85b9cec260bc
Fix a bug occuring when using certain actions on a collection
item which is not in the selection.
Triggering it will either result in an assertion failure or a
segfault.
To reproduce:
- open a collection
- right-click on a non-selected image
- select Delete... menu entry (or Copy, Move, Rename, Properties...)
It results in the best case:
** ERROR **: file filelist.c: line 905 (file_data_ref): assertion failed: (fd->magick == 0x12345678)
or a pure segfault due to corrupted data.
collection_table_popup_file_list() has to return a list of filedata *
not a list of gchar *.
author | zas_ |
---|---|
date | Sat, 03 May 2008 16:58:17 +0000 |
parents | 86f4c42afeab |
children | f31ae0d9e163 |
line wrap: on
line source
Please keep the general coding style of Geeqie: Space after if, while and for: while (...) for (...) if (...) Indentation of {}: while (...) { ... } if (...) { ... } else { ... } Spaces around operators: i = 2; Space after comma: func(a, b, c); Use glib functions when possible (ie. g_ascii_isspace() instead of isspace()). Please use glib types when possible (ie. gint and gchar instead of int and char) . Check twice the indentation and spurious whitespaces. Try to use explicit variable and function names