Mercurial > libavcodec.hg

changeset 7283:39e81fdd8d23 libavcodec

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Move the size of the H264Context delayed_pic array into a #define. This improves readability by getting rid of some magic numbers.
author astrange
date Tue, 15 Jul 2008 21:30:04 +0000
parents dc5a334c758b
children a40ae5adf74c
files h264.c h264.h
diffstat 2 files changed, 5 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/h264.c	Tue Jul 15 19:06:32 2008 +0000
+++ b/h264.c	Tue Jul 15 21:30:04 2008 +0000
@@ -3302,7 +3302,7 @@
 static void flush_dpb(AVCodecContext *avctx){
     H264Context *h= avctx->priv_data;
     int i;
-    for(i=0; i<16; i++) {
+    for(i=0; i<MAX_DELAYED_PIC_COUNT; i++) {
         if(h->delayed_pic[i])
             h->delayed_pic[i]->reference= 0;
         h->delayed_pic[i]= NULL;
@@ -7836,7 +7836,7 @@
             pics = 0;
             while(h->delayed_pic[pics]) pics++;
 
-            assert(pics+1 < sizeof(h->delayed_pic) / sizeof(h->delayed_pic[0]));
+            assert(pics <= MAX_DELAYED_PIC_COUNT);
 
             h->delayed_pic[pics++] = cur;
             if(cur->reference == 0)
--- a/h264.h	Tue Jul 15 19:06:32 2008 +0000
+++ b/h264.h	Tue Jul 15 21:30:04 2008 +0000
@@ -51,6 +51,8 @@
 
 #define MAX_MMCO_COUNT 66
 
+#define MAX_DELAYED_PIC_COUNT 16
+
 /* Compiling in interlaced support reduces the speed
  * of progressive decoding by about 2%. */
 #define ALLOW_INTERLACE
@@ -334,7 +336,7 @@
     Picture ref_list[2][48];         /**< 0..15: frame refs, 16..47: mbaff field refs.
                                           Reordered version of default_ref_list
                                           according to picture reordering in slice header */
-    Picture *delayed_pic[18]; //FIXME size?
+    Picture *delayed_pic[MAX_DELAYED_PIC_COUNT+2]; //FIXME size?
     Picture *delayed_output_pic;
 
     /**