changeset 4630:e04458242c54 libavformat

Reduce allocated length of the HTTP authentication request field buffer, as noticed by Stefano and Luca in the "[PATCH]RTSP Basic Authentication" mailinglist thread. av_base64_encode() was recently changed. The previous implementation required 12 extra bytes (ceil(len(src)/3.)*4+12), whereas the new one is guaranteed to fit in an exact buffer (ceil(len(src)/3.)*4), plus one extra byte for the trailing zero. This change fixes no bug, it just slightly decreases the amount of allocated memory.
author rbultje
date Tue, 03 Mar 2009 13:26:17 +0000
parents 3176b13b0881
children 4bbf1fe0796b
files http.c
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/http.c	Tue Mar 03 12:57:07 2009 +0000
+++ b/http.c	Tue Mar 03 13:26:17 2009 +0000
@@ -212,7 +212,7 @@
     int post, err, ch;
     char line[1024], *q;
     char *auth_b64;
-    int auth_b64_len = strlen(auth)* 4 / 3 + 12;
+    int auth_b64_len = (strlen(auth) + 2) / 3 * 4 + 1;
     int64_t off = s->off;