comparison gui/mplayer/gui_common.c @ 32979:4905f5a87357

Replace some awkward and unnecessary usages of strlen(). 1. A string length of zero or greater than zero can be determined by checking the first byte. 2. Leave it to strdup() to determine the length and to do allocation for a string that is to be copied. 3. If neither the string length nor the index variable is altered in a loop, string[index] (!= 0) is the condition to go with.

32978:b68d209b6f28

        av_strlcpy(tmp, MSGTR_NoMediaOpened, tmplen);
        break;
    }

    if (c) {
        for (i = 0; i < (int)strlen(tmp); i++) {
            int t = 0;

            if (c == 1)
                if (tmp[i] >= 'A' && tmp[i] <= 'Z')
                    t = 32;

32979:4905f5a87357

        av_strlcpy(tmp, MSGTR_NoMediaOpened, tmplen);
        break;
    }

    if (c) {
        for (i = 0; tmp[i]; i++) {
            int t = 0;

            if (c == 1)
                if (tmp[i] >= 'A' && tmp[i] <= 'Z')
                    t = 32;