Mercurial > mplayer.hg

diff gui/mplayer/gui_common.c @ 32979:4905f5a87357

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Replace some awkward and unnecessary usages of strlen(). 1. A string length of zero or greater than zero can be determined by checking the first byte. 2. Leave it to strdup() to determine the length and to do allocation for a string that is to be copied. 3. If neither the string length nor the index variable is altered in a loop, string[index] (!= 0) is the condition to go with.
author ib
date Thu, 10 Mar 2011 14:20:36 +0000
parents 0dc9d64cd64e
children ff85d256c53e
line wrap: on
line diff
--- a/gui/mplayer/gui_common.c	Thu Mar 10 13:22:11 2011 +0000
+++ b/gui/mplayer/gui_common.c	Thu Mar 10 14:20:36 2011 +0000
@@ -91,7 +91,7 @@
     }
 
     if (c) {
-        for (i = 0; i < (int)strlen(tmp); i++) {
+        for (i = 0; tmp[i]; i++) {
             int t = 0;
 
             if (c == 1)