changeset 16836:a5ff3d90f16d

comment on -noskip patch
author rfelker
date Sun, 23 Oct 2005 15:05:11 +0000
parents 527c1561a0ad
children 098d3c815fe2
files mencoder.c
diffstat 1 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mencoder.c	Sun Oct 23 14:49:32 2005 +0000
+++ b/mencoder.c	Sun Oct 23 15:05:11 2005 +0000
@@ -1302,6 +1302,11 @@
 	// unwanted skipping of a frame, what to do?
         v_timer_corr-=(float)mux_v->h.dwScale/mux_v->h.dwRate;
 #if 0
+        // Old code apparently made under the assumption that !blit_frame means
+        // decoding failed due to corruption or something.. but duplication and
+        // skipping of frames should be entirely disabled when skip_limit==0,
+        // and must be in order for many filters to work with -noskip.
+        // Eventually this entire block should probably be removed.
 	if(skip_limit==0){
 	    // skipping not allowed -> write empty frame:
 	    if (!encode_duplicates || !sh_video->vfilter || ((vf_instance_t *)sh_video->vfilter)->control(sh_video->vfilter, VFCTRL_DUPLICATE_FRAME, 0) != CONTROL_TRUE)