Mercurial > pidgin.yaz
annotate COPYRIGHT @ 8672:142108e89399
[gaim-migrate @ 9424]
"This patch contains two fixes. The first is rather trivial, just removes
the declaration of extra pointer used for deleting a message and
deletes the message directly.
The second is the real bug that needed fixing.
Short Explanation:
The old code only fixed the message that was being displayed, and
still sent the original unchecked message to the receiving party. All I
did was add a handler to the load_plugin function to make it fix the
message being sent as well.
Longer Explanation:
In my cursory look through the gaim code (warning, <15 minutes) it
appears the message pointer send to all the various *-im-msg and
*-chat-msg handlers is a copy of the original string each time. This
means if you fix the string at one stage (displaying), you have to fix it
again at the next (sending). This seems rather inefficient, but hey, it's
your client, maybe it was a design feature.
Anyway, the spellchk plugin was only fixing the displayed
message, and not the message being sent. So I thought my messages
were being fixed while those receiving them new I was screwing up. I
added substitute_somethingorother handler for the sending-im-msg
callback in the load_plugin function.
Other comments:
I didn't look to deeply into it since it's so late, but the
"displaying-chat-msg" and "sending-chat-msg" callbacks appear to
be broken. The spellchk.c currently has a handler registered for the
first callback, but the message displayed on my screen still contains
the original typos. If I try to register a handler for the second callback
listed, Gaim crashes when sending the message to a chat window. As
I said, I didn't look into why it was crashing, I just removed my
attempt to handle it and built this patch." --Matt Brenneke
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Fri, 16 Apr 2004 14:39:34 +0000 |
| parents | f95edb58087c |
| children | aebfa2b6af6b |
| rev | line source |
|---|---|
| 8046 | 1 Gaim |
| 2 Copyright (C) 1998-2004 by the following: | |
| 3 | |
| 4 If you have contributed to Gaim, you deserve to be on this list. | |
| 5 Contact us (see: AUTHORS) and we'll add you. | |
| 6 | |
| 7967 | 7 Daniel Atallah |
| 8598 | 8 Paul Aurich |
| 7959 | 9 Patrick Aussems |
| 8266 | 10 Kevin Barry |
| 7958 | 11 Brian Bernas |
| 7959 | 12 Jonas Birmé |
| 7958 | 13 Ethan Blanton |
| 7959 | 14 Joshua Blanton |
| 7958 | 15 Herman Bloggs |
| 16 Jason Boerner | |
| 7959 | 17 Graham Booker |
| 18 Craig Boston | |
| 19 Chris Boyle | |
| 8672 | 20 Matt Brenneke |
| 7958 | 21 Jeremy Brooks |
| 8139 | 22 Philip Brown |
| 7959 | 23 Sean Burke |
| 24 Cerulean Studios, LLC | |
| 25 Ka-Hing Cheung | |
| 26 Arturo Cisneros, Jr. | |
| 27 Vincas Ciziunas | |
| 7958 | 28 Joe Clarke |
| 7959 | 29 Todd Cohen |
| 30 Felipe Contreras | |
| 31 Jeramey Crawford | |
| 32 Mark Doliner | |
| 33 Nuno Donato | |
| 34 Jim Duchek | |
| 35 Tom Dyas | |
| 8664 | 36 Marc E. |
| 7959 | 37 Andrew Echols |
| 38 Sean Egan <sean.egan@binghamton.edu> | |
| 39 Brian Enigma | |
| 7998 | 40 Stefan Esser |
| 7958 | 41 Larry Ewing |
| 7959 | 42 Jesse Farmer |
| 7983 | 43 Gavan Fantom (gavan) |
| 8195 | 44 Rob Flynn <gaim@robflynn.com> |
| 8384 | 45 Rob (rwf) Foehl |
| 7958 | 46 Nathan Fredrickson |
| 8267 | 47 Chris J. Friesen |
| 8048 | 48 Free Software Foundation |
| 7959 | 49 Decklin Foster |
| 50 Adam Fritzler | |
| 8209 | 51 Max G. |
| 8160 | 52 Ignacy Gawedzki |
| 7959 | 53 Michael Golden |
| 54 Ryan C. Gordon | |
| 55 Christian Hammond | |
| 8124 | 56 Benjamin Herrenschmidt |
| 7959 | 57 Andy Harrison |
| 58 G. Sumner Hayes | |
| 59 Mike Heffner | |
| 8046 | 60 Iain Holmes |
| 7959 | 61 Karsten Huneycutt |
| 62 Akuke Kok | |
| 8124 | 63 Gary Kramlich |
| 7959 | 64 Tero Kuusela |
|
8273
f24172f53650
[gaim-migrate @ 8997]
Christian Hammond <chipx86@chipx86.com>
parents:
8267
diff
changeset
|
65 Scott Lamb |
| 7959 | 66 Dennis Lambe Jr. |
| 8444 | 67 Daniel Larsson |
| 7959 | 68 Ho-seok Lee |
| 69 Moses Lei | |
| 70 Ambrose C. Li | |
| 7957 | 71 Nicolas Lichtmaier |
| 7959 | 72 Artem Litvinovich |
| 73 Syd Logan | |
| 8220 | 74 Uli Luckas |
| 7959 | 75 Matthew Luckie |
| 76 Brian Macke | |
| 8046 | 77 Paolo Maggi |
| 7959 | 78 Willian T. Mahan |
| 79 John Matthews | |
| 80 Ryan McCabe | |
| 8656 | 81 Kurt McKee |
| 7957 | 82 Robert McQueen |
| 83 Robert Mibus | |
| 7959 | 84 Benjamin Miller |
| 85 Kevin Miller | |
| 86 Paul Miller | |
| 87 Arkadiusz Miskiewicz | |
| 88 Andrew Molloy | |
| 8241 | 89 Padraig O'Briain |
| 8562 | 90 Christopher (siege) O'Brien |
| 8334 | 91 Nathan (pianocomp81) Owens |
| 7959 | 92 Matt Pandina |
| 8046 | 93 Ricardo Fernandez Pascual |
| 94 Havoc Pennington | |
| 7959 | 95 Ari Pollak |
| 7957 | 96 Robey Pointer |
| 7959 | 97 Nathan Poznick |
| 98 Brent Priddy | |
| 99 Federicco Mena Quintero | |
| 100 David Raeman | |
| 101 Etan Reisner | |
| 102 Kristian Rietveld | |
|
8332
f4a878d48254
[gaim-migrate @ 9056]
Christian Hammond <chipx86@chipx86.com>
parents:
8273
diff
changeset
|
103 Pekka Riikonen |
| 7959 | 104 Tim Ringenbach |
| 105 Andrew Rodland | |
| 106 Neil Sanchala | |
| 8046 | 107 Carsten Schaar |
| 7959 | 108 Luke Schierer |
|
8208
bfbba1a7710a
[gaim-migrate @ 8931]
Christian Hammond <chipx86@chipx86.com>
parents:
8204
diff
changeset
|
109 Evan Schoenberg |
| 7959 | 110 Torrey Searle |
| 111 Jim Seymour | |
| 112 John Silvestri | |
| 8204 | 113 Alex Smith |
| 7959 | 114 David Smock |
| 115 Mark Spencer <markster@marko.net> | |
| 116 Lex Spoon | |
| 117 Kevin Stange | |
| 118 David Stoddard | |
| 8153 | 119 Sun Microsystems |
| 8217 | 120 Mårten (fursten) Svantesson |
| 7959 | 121 Brian Tarricone |
| 122 Peter Teichman | |
| 8118 | 123 Philip Tellis |
| 7959 | 124 Arun A. Tharuvai |
| 8118 | 125 Douglas (douglaswth) Thrift |
| 8124 | 126 Stu Tomlinson |
| 7959 | 127 Bill Tompkins |
| 8046 | 128 Tom Tromey |
|
8474
8b62cc40069b
[gaim-migrate @ 9207]
Christian Hammond <chipx86@chipx86.com>
parents:
8444
diff
changeset
|
129 Chris Toshok |
| 7959 | 130 Junichi Uekawa |
|
8518
833dd756dcc3
[gaim-migrate @ 9257]
Christian Hammond <chipx86@chipx86.com>
parents:
8482
diff
changeset
|
131 David Vermeille |
| 7959 | 132 Bjoern Voigt |
| 133 Nathan Walp | |
| 134 Eric Warmenhoven | |
| 8482 | 135 Andrew Wellington |
| 8091 | 136 Dan Willemsen |
| 7959 | 137 Jason Willis |
| 138 Matt Wilson | |
| 7957 | 139 Ximian |
| 8436 | 140 Jared Yanovich |
|
8661
060171053a32
[gaim-migrate @ 9413]
Christian Hammond <chipx86@chipx86.com>
parents:
8656
diff
changeset
|
141 Nickolai Zeldovich |
| 8235 | 142 Marco Ziech |
| 8046 | 143 Jaroen Zwartepoorte |