Mercurial > pidgin.yaz
comparison libpurple/protocols/yahoo/libymsg.c @ 30113:708c35476cff
yahoo: Add a FIXME. Refs #10346, #10746.
I think the cause of those crashes is that two calls to
purple_network_listen() can be outstanding (yahoo_send_p2p_pkt only checks
if something is /currently listening/, not if a listen attempt is in
progress). It might also be that listen attempts aren't cancelled when
an account signs off (unlike purple_proxy_connects). I could also be
entirely off-base.
author | Paul Aurich <paul@darkrain42.org> |
---|---|
date | Sun, 11 Apr 2010 05:15:29 +0000 |
parents | ccaaee2a8e59 |
children | bd0ce3844104 04c84a3f9553 |
comparison
equal
deleted
inserted
replaced
30112:b4cd989f524f | 30113:708c35476cff |
---|---|
2761 p2p_data->host_username = g_strdup(who); | 2761 p2p_data->host_username = g_strdup(who); |
2762 p2p_data->val_13 = val_13; | 2762 p2p_data->val_13 = val_13; |
2763 p2p_data->connection_type = YAHOO_P2P_WE_ARE_SERVER; | 2763 p2p_data->connection_type = YAHOO_P2P_WE_ARE_SERVER; |
2764 p2p_data->source = -1; | 2764 p2p_data->source = -1; |
2765 | 2765 |
2766 /* FIXME: Shouldn't this deal with the PurpleNetworkListenData* */ | |
2766 purple_network_listen(YAHOO_PAGER_PORT_P2P, SOCK_STREAM, yahoo_p2p_server_listen_cb, p2p_data); | 2767 purple_network_listen(YAHOO_PAGER_PORT_P2P, SOCK_STREAM, yahoo_p2p_server_listen_cb, p2p_data); |
2767 | 2768 |
2768 g_free(base64_ip); | 2769 g_free(base64_ip); |
2769 } | 2770 } |
2770 | 2771 |