changeset 30113:708c35476cff

yahoo: Add a FIXME. Refs #10346, #10746. I think the cause of those crashes is that two calls to purple_network_listen() can be outstanding (yahoo_send_p2p_pkt only checks if something is /currently listening/, not if a listen attempt is in progress). It might also be that listen attempts aren't cancelled when an account signs off (unlike purple_proxy_connects). I could also be entirely off-base.
author Paul Aurich <paul@darkrain42.org>
date Sun, 11 Apr 2010 05:15:29 +0000
parents b4cd989f524f
children 9f298b02e0d8
files libpurple/protocols/yahoo/libymsg.c
diffstat 1 files changed, 1 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/yahoo/libymsg.c	Sat Apr 10 23:16:47 2010 +0000
+++ b/libpurple/protocols/yahoo/libymsg.c	Sun Apr 11 05:15:29 2010 +0000
@@ -2763,6 +2763,7 @@
 	p2p_data->connection_type = YAHOO_P2P_WE_ARE_SERVER;
 	p2p_data->source = -1;
 
+	/* FIXME: Shouldn't this deal with the PurpleNetworkListenData* */
 	purple_network_listen(YAHOO_PAGER_PORT_P2P, SOCK_STREAM, yahoo_p2p_server_listen_cb, p2p_data);
 
 	g_free(base64_ip);