changeset 23248:2567a386f3a8

Wow, this isn't used. That will save us either 4 bytes or 8 bytes for each PurpleStatus, depending on whether you're on a 32 bit or 64 bit OS. We create a full set of PurpleStatuses (between 2 and maybe 10, depending on the protocol) for each PurplePresence, and each buddy in your buddylist has a PurplePresence. Assuming you on a 64 bit machine, you have 200 buddies, and you're using a protocol with 8 PurpleStatusTypes, this saves you 12KB of memory. Eh, I guess that's not so bad. Our status system is pretty memory inefficient right now... we tend to duplicate a lot of stuff from the PurpleStatusTypes unneccessarily. I think we can probably get a way with NOT duplicating it and having PurplePresence and PurpleStatus look through to the PurpleStatusTypes as appropriate. But it'll break our API a little, so we can't do it until 3.0.0.
author Mark Doliner <mark@kingant.net>
date Thu, 29 May 2008 17:41:08 +0000
parents 073ae152b481
children a903c3fcbe43
files libpurple/status.c
diffstat 1 files changed, 0 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/status.c	Thu May 29 15:30:26 2008 +0000
+++ b/libpurple/status.c	Thu May 29 17:41:08 2008 +0000
@@ -107,8 +107,6 @@
 	PurpleStatusType *type;
 	PurplePresence *presence;
 
-	const char *title;
-
 	gboolean active;
 
 	/*