changeset 17018:481e8da0d6a2

Remove the fatal asserts. If you think they helped you find and fix bugs, you can use 'G_DEBUG=fatal_warnings pidgin' to get back the crashes.
author Sadrul Habib Chowdhury <imadil@gmail.com>
date Thu, 10 May 2007 21:45:55 +0000
parents 1b0860202e9f
children 3130a2cfe4e0
files configure.ac pidgin/gtkmain.c
diffstat 2 files changed, 5 insertions(+), 12 deletions(-) [+]
line wrap: on
line diff
--- a/configure.ac	Thu May 10 03:56:05 2007 +0000
+++ b/configure.ac	Thu May 10 21:45:55 2007 +0000
@@ -996,6 +996,10 @@
 		])
 	fi
 
+	if test "x$enable_debug" = "xyes"; then
+		CFLAGS="$CFLAGS -O0"
+	fi
+
 	DEBUG_CFLAGS="-Wall $DEBUG_CFLAGS"
 	CFLAGS="-g $CFLAGS"
 fi
@@ -2000,16 +2004,11 @@
 
 AC_ARG_ENABLE(debug, [AC_HELP_STRING([--enable-debug],
 	[compile with debugging support])], , enable_debug=no)
+
 if test "x$enable_debug" = "xyes" ; then
 	AC_DEFINE(DEBUG, 1, [Define if debugging is enabled.])
 fi
 
-AC_ARG_ENABLE(fatal-asserts, [AC_HELP_STRING([--enable-fatal-asserts],
-	[make assertions fatal (useful for debugging)])], , enable_fatal_asserts=no)
-if test "x$enable_fatal_asserts" = "xyes" ; then
-	AC_DEFINE(PURPLE_FATAL_ASSERTS, 1, [Define to make assertions fatal (useful for debugging).])
-fi
-
 AC_OUTPUT([Makefile
 		   Doxyfile
 		   doc/Makefile
@@ -2158,7 +2157,6 @@
 echo Build with Tk support......... : $enable_tk
 echo
 echo Print debugging messages...... : $enable_debug
-echo Assertions are fatal.......... : $enable_fatal_asserts
 echo
 eval eval echo Pidgin will be installed in $bindir.
 if test "x$pidginpath" != "x" ; then
--- a/pidgin/gtkmain.c	Thu May 10 03:56:05 2007 +0000
+++ b/pidgin/gtkmain.c	Thu May 10 21:45:55 2007 +0000
@@ -477,11 +477,6 @@
 	/* This is the first Glib function call. Make sure to initialize GThread bfeore then */
 	g_thread_init(NULL);
 	
-#ifdef PURPLE_FATAL_ASSERTS
-	/* Make g_return_... functions fatal. */
-	g_log_set_always_fatal(G_LOG_LEVEL_CRITICAL);
-#endif
-
 #ifdef ENABLE_NLS
 	bindtextdomain(PACKAGE, LOCALEDIR);
 	bind_textdomain_codeset(PACKAGE, "UTF-8");