Mercurial > pidgin.yaz
changeset 31352:63aeff4ebc19
jabber: Avoid a double-free in the google relay code.
Also some whitespace clean-up right next to the double-free. Reported by
"mordy" in #pidgin.
| author | Paul Aurich <paul@darkrain42.org> |
|---|---|
| date | Mon, 08 Nov 2010 17:05:18 +0000 |
| parents | d87c49564564 |
| children | a4f3d21f393c |
| files | ChangeLog libpurple/protocols/jabber/google/google_session.c |
| diffstat | 2 files changed, 5 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Mon Nov 01 14:20:44 2010 +0000 +++ b/ChangeLog Mon Nov 08 17:05:18 2010 +0000 @@ -10,6 +10,9 @@ (http://developer.pidgin.im/wiki/SlpArchitecture) * Lots of little changes. + XMPP: + * Avoid a double-free in the Google Relay (V/V) code. + version 2.7.5 (10/31/2010): General: * Added Verisign Class 3 Public CA - G2 root CA.
--- a/libpurple/protocols/jabber/google/google_session.c Mon Nov 01 14:20:44 2010 +0000 +++ b/libpurple/protocols/jabber/google/google_session.c Mon Nov 08 17:05:18 2010 +0000 @@ -372,7 +372,7 @@ params = jabber_google_session_get_params(js, relay_ip, relay_udp, relay_tcp, relay_ssltcp, relay_username, relay_password, &num_params); - + if (purple_media_add_stream(session_data->media, "google-voice", session->remote_jid, PURPLE_MEDIA_AUDIO, TRUE, "nice", num_params, params) == FALSE || @@ -382,12 +382,11 @@ TRUE, "nice", num_params, params) == FALSE)) { purple_media_error(session_data->media, "Error adding stream."); purple_media_end(session_data->media, NULL, NULL); - g_free(params); } else { session_data->added_streams = TRUE; } - g_free(params); + g_free(params); }