changeset 28731:ae7348244f56

Swap two lines to fix a crash. msn_servconn_disconnect can destroy servconn, which makes it crash on the next line. So reset the idle-handler before going into that function.
author Sadrul Habib Chowdhury <imadil@gmail.com>
date Sun, 11 Oct 2009 19:20:44 +0000
parents 428d85859b4e
children 4a917f91bc05
files libpurple/protocols/msn/servconn.c
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/servconn.c	Sat Oct 10 19:47:30 2009 +0000
+++ b/libpurple/protocols/msn/servconn.c	Sun Oct 11 19:20:44 2009 +0000
@@ -299,8 +299,8 @@
 static gboolean
 servconn_idle_timeout_cb(MsnServConn *servconn)
 {
+	servconn->timeout_handle = 0;
 	msn_servconn_disconnect(servconn);
-	servconn->timeout_handle = 0;	/* XXX: servconn may not be valid anymore */
 	return FALSE;
 }