changeset 23399:e1bddd9c5c88

jabber_google_roster_add_deny() and jabber_google_roster_rem_deny() previously recreated the iq, query, and item after inserting group information, nullifying the usefulness of having done so. I don't know of a specific problem which this fixes, as I just noticed it while investigating the "jabber:iq:roster" infinite loop discussed on pidgin-devl and in #5484
author Evan Schoenberg <evan.s@dreskin.net>
date Tue, 01 Jul 2008 04:26:19 +0000
parents 47b709962aab
children 074be48b20e7
files libpurple/protocols/jabber/google.c
diffstat 1 files changed, 0 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/jabber/google.c	Mon Jun 30 22:58:18 2008 +0000
+++ b/libpurple/protocols/jabber/google.c	Tue Jul 01 04:26:19 2008 +0000
@@ -314,11 +314,6 @@
 		buddies = buddies->next;
 	}
 
-	iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster");
-
-	query = xmlnode_get_child(iq->node, "query");
-	item = xmlnode_new_child(query, "item");
-
 	xmlnode_set_attrib(item, "jid", who);
 	xmlnode_set_attrib(item, "name", b->alias ? b->alias : "");
 	xmlnode_set_attrib(item, "gr:t", "B");
@@ -385,11 +380,6 @@
 		buddies = buddies->next;
 	}
 
-	iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster");
-
-	query = xmlnode_get_child(iq->node, "query");
-	item = xmlnode_new_child(query, "item");
-
 	xmlnode_set_attrib(item, "jid", who);
 	xmlnode_set_attrib(item, "name", b->alias ? b->alias : "");
 	xmlnode_set_attrib(query, "xmlns:gr", "google:roster");