Mercurial > pidgin
annotate src/dbus-useful.c @ 12288:3897229ccb33
[gaim-migrate @ 14592]
" This patch fixes two serious bugs in the hidden
conversation/queuing code.
First, it removes the need to explicitly present
conversations created under queuing conditions.
Instead, when an incoming message is received and a
conversation does not exist, a hidden conversation is
created in a received-im-msg signal handler by swapping
out the create_conversation function in the gtkconv
ui_ops. This fixes a bug which could allow
conversations to be created in a hidden state when they
should be visible (i.e. buddy pounce open an im window
action). This required a second search for a
conversation in server.c after the signal is emitted.
Second, it fixes a bug which would cause gaim to crash
when quitting with a queued message. Fixing this
simplified the code a bit by removing the
private_remove_gtkconv function and instead adding a
check in gaim_gtk_conv_window_remove_gtkconv to prevent
the hidden_convwin from being destroyed when the last
conversation is removed." --charkins
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Fri, 02 Dec 2005 00:40:32 +0000 |
parents | c9312177821a |
children | 8bda65b88e49 |
rev | line source |
---|---|
11187 | 1 #include <string.h> |
2 #include <glib.h> | |
3 | |
11331 | 4 #include "dbus-useful.h" |
11146 | 5 #include "conversation.h" |
11187 | 6 #include "util.h" |
7 | |
11146 | 8 |
9 GaimAccount * | |
10 gaim_accounts_find_ext(const char *name, const char *protocol_id, | |
11 gboolean (*account_test)(const GaimAccount *account)) | |
12 { | |
11903 | 13 GaimAccount *result = NULL; |
11146 | 14 GList *l; |
15 char *who; | |
16 | |
17 if (name) | |
18 who = g_strdup(gaim_normalize(NULL, name)); | |
19 else | |
20 who = NULL; | |
21 | |
22 for (l = gaim_accounts_get_all(); l != NULL; l = l->next) { | |
23 GaimAccount *account = (GaimAccount *)l->data; | |
24 | |
25 if (who && strcmp(gaim_normalize(NULL, gaim_account_get_username(account)), who)) | |
26 continue; | |
27 | |
28 if (protocol_id && strcmp(account->protocol_id, protocol_id)) | |
29 continue; | |
30 | |
31 if (account_test && !account_test(account)) | |
32 continue; | |
33 | |
34 result = account; | |
35 break; | |
36 } | |
37 | |
38 g_free(who); | |
39 | |
40 return result; | |
41 } | |
42 | |
43 GaimAccount *gaim_accounts_find_any(const char *name, const char *protocol) | |
44 { | |
45 return gaim_accounts_find_ext(name, protocol, NULL); | |
46 } | |
47 | |
48 GaimAccount *gaim_accounts_find_connected(const char *name, const char *protocol) | |
49 { | |
50 return gaim_accounts_find_ext(name, protocol, gaim_account_is_connected); | |
51 } | |
52 | |
53 |