annotate libpurple/protocols/yahoo/yahoo_aliases.c @ 25622:e4d738813cd8

Backport the parts of b859960a4a19f57f20db0536c1815a6d79e08e36 that apply to this branch, and also apply 162a734100aafd62b7338baa81b04510c6b66921.
author John Bailey <rekkanoryo@rekkanoryo.org>
date Fri, 19 Jun 2009 01:18:18 +0000
parents c0226e400836
children 8965e9730987
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
1 /*
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
2 * purple
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
3 *
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
4 * Purple is the legal property of its developers, whose names are too numerous
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
5 * to list here. Please refer to the COPYRIGHT file distributed with this
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
6 * source distribution.
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
7 *
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
8 * This program is free software; you can redistribute it and/or modify
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
9 * it under the terms of the GNU General Public License as published by
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
10 * the Free Software Foundation; either version 2 of the License, or
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
11 * (at your option) any later version.
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
12 *
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
13 * This program is distributed in the hope that it will be useful,
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
16 * GNU General Public License for more details.
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
17 *
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
18 * You should have received a copy of the GNU General Public License
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
19 * along with this program; if not, write to the Free Software
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
21 *
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
22 */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
23
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
24
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
25 #include "internal.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
26
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
27 #include "account.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
28 #include "accountopt.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
29 #include "blist.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
30 #include "debug.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
31 #include "util.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
32 #include "version.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
33 #include "yahoo.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
34 #include "yahoo_aliases.h"
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
35 #include "yahoo_friend.h"
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
36 #include "yahoo_packet.h"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
37
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
38 /* I hate hardcoding this stuff, but Yahoo never sends us anything to use. Someone in the know may be able to tweak this URL */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
39 #define YAHOO_ALIAS_FETCH_URL "http://address.yahoo.com/yab/us?v=XM&prog=ymsgr&.intl=us&diffs=1&t=0&tags=short&rt=0&prog-ver=8.1.0.249&useutf8=1&legenc=codepage-1252"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
40 #define YAHOO_ALIAS_UPDATE_URL "http://address.yahoo.com/yab/us?v=XM&prog=ymsgr&.intl=us&sync=1&tags=short&noclear=1&useutf8=1&legenc=codepage-1252"
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
41 #define YAHOOJP_ALIAS_FETCH_URL "http://address.yahoo.co.jp/yab/jp?v=XM&prog=ymsgr&.intl=jp&diffs=1&t=0&tags=short&rt=0&prog-ver=7.0.0.7"
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
42 #define YAHOOJP_ALIAS_UPDATE_URL "http://address.yahoo.co.jp/yab/jp?v=XM&prog=ymsgr&.intl=jp&sync=1&tags=short&noclear=1"
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
43
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
44 void yahoo_update_alias(PurpleConnection *gc, const char *who, const char *alias);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
45
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
46 /**
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
47 * Stuff we want passed to the callback function
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
48 */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
49 struct callback_data {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
50 PurpleConnection *gc;
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
51 gchar *id;
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
52 gchar *who;
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
53 };
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
54
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
55
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
56 /**************************************************************************
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
57 * Alias Fetch Functions
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
58 **************************************************************************/
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
59
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
60 static void
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
61 yahoo_fetch_aliases_cb(PurpleUtilFetchUrlData *url_data, gpointer user_data, const gchar *url_text, size_t len, const gchar *error_message)
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
62 {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
63 struct callback_data *cb = user_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
64 PurpleConnection *gc = cb->gc;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
65 struct yahoo_data *yd = gc->proto_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
66
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
67 yd->url_datas = g_slist_remove(yd->url_datas, url_data);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
68
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
69 if (len == 0) {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
70 purple_debug_info("yahoo", "No Aliases to process.%s%s\n",
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
71 error_message ? " Error:" : "", error_message ? error_message : "");
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
72 } else {
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
73 gchar *full_name, *nick_name;
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
74 const char *yid, *id, *fn, *ln, *nn, *alias;
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
75 YahooFriend *f;
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
76 PurpleBuddy *b;
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
77 xmlnode *item, *contacts;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
78
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
79 /* Put our web response into a xmlnode for easy management */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
80 contacts = xmlnode_from_str(url_text, -1);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
81
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
82 if (contacts == NULL) {
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
83 purple_debug_error("yahoo", "Badly formed Alias XML\n");
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
84 g_free(cb->who);
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
85 g_free(cb->id);
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
86 g_free(cb);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
87 return;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
88 }
22486
3225c99785b8 Fix a bunch of compiler warnings caused by my addition of G_GNUC_PRINTF()
Mark Doliner <mark@kingant.net>
parents: 22330
diff changeset
89 purple_debug_info("yahoo", "Fetched %" G_GSIZE_FORMAT
3225c99785b8 Fix a bunch of compiler warnings caused by my addition of G_GNUC_PRINTF()
Mark Doliner <mark@kingant.net>
parents: 22330
diff changeset
90 " bytes of alias data\n", len);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
91
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
92 /* Loop around and around and around until we have gone through all the received aliases */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
93 for(item = xmlnode_get_child(contacts, "ct"); item; item = xmlnode_get_next_twin(item)) {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
94 /* Yahoo replies with two types of contact (ct) record, we are only interested in the alias ones */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
95 if ((yid = xmlnode_get_attrib(item, "yi"))) {
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
96 /* Grab all the bits of information we can */
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
97 fn = xmlnode_get_attrib(item, "fn");
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
98 ln = xmlnode_get_attrib(item, "ln");
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
99 nn = xmlnode_get_attrib(item, "nn");
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
100 id = xmlnode_get_attrib(item, "id");
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
101
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
102 full_name = nick_name = NULL;
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
103 alias = NULL;
22818
0d7ceae153bd Leak fixes.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22486
diff changeset
104
0d7ceae153bd Leak fixes.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22486
diff changeset
105 /* Yahoo stores first and last names separately, lets put them together into a full name */
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
106 if (yd->jp)
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
107 full_name = g_strstrip(g_strdup_printf("%s %s", (ln != NULL ? ln : "") , (fn != NULL ? fn : "")));
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
108 else
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
109 full_name = g_strstrip(g_strdup_printf("%s %s", (fn != NULL ? fn : "") , (ln != NULL ? ln : "")));
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
110 nick_name = (nn != NULL ? g_strstrip(g_strdup(nn)) : NULL);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
111
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
112 if (nick_name != NULL)
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
113 alias = nick_name; /* If we have a nickname from Yahoo, let's use it */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
114 else if (strlen(full_name) != 0)
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
115 alias = full_name; /* If no Yahoo nickname, we can use the full_name created above */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
116
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
117 /* Find the local buddy that matches */
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
118 f = yahoo_friend_find(cb->gc, yid);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
119 b = purple_find_buddy(cb->gc->account, yid);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
120
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
121 /* If we don't find a matching buddy, ignore the alias !! */
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
122 if (f != NULL && b != NULL) {
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
123 const char *buddy_alias = purple_buddy_get_alias(b);
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
124 yahoo_friend_set_alias_id(f, id);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
125
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
126 /* Finally, if we received an alias, we better update the buddy list */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
127 if (alias != NULL) {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
128 serv_got_alias(cb->gc, yid, alias);
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
129 purple_debug_info("yahoo", "Fetched alias '%s' (%s)\n", alias, id);
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
130 } else if (buddy_alias != NULL && strcmp(buddy_alias, "") != 0) {
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
131 /* Or if we have an alias that Yahoo doesn't, send it up */
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
132 yahoo_update_alias(cb->gc, yid, buddy_alias);
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
133 purple_debug_info("yahoo", "Sent updated alias '%s'\n", buddy_alias);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
134 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
135 }
22818
0d7ceae153bd Leak fixes.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22486
diff changeset
136
0d7ceae153bd Leak fixes.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22486
diff changeset
137 g_free(full_name);
0d7ceae153bd Leak fixes.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22486
diff changeset
138 g_free(nick_name);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
139 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
140 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
141 xmlnode_free(contacts);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
142 }
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
143
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
144 g_free(cb->who);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
145 g_free(cb->id);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
146 g_free(cb);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
147 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
148
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
149 void
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
150 yahoo_fetch_aliases(PurpleConnection *gc)
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
151 {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
152 struct yahoo_data *yd = gc->proto_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
153 struct callback_data *cb;
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
154 const char *url;
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
155 gchar *request, *webpage, *webaddress;
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
156 PurpleUtilFetchUrlData *url_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
157
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
158 /* use whole URL if using HTTP Proxy */
23986
18a1f0fe5f40 Do a better job of detecting if the yahoo account is connecting through a HTTP
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23017
diff changeset
159 gboolean use_whole_url = yahoo_account_use_http_proxy(gc);
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
160
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
161 /* Using callback_data so I have access to gc in the callback function */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
162 cb = g_new0(struct callback_data, 1);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
163 cb->gc = gc;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
164
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
165 /* Build all the info to make the web request */
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
166 url = yd->jp ? YAHOOJP_ALIAS_FETCH_URL : YAHOO_ALIAS_FETCH_URL;
21016
abd768f06e7b Another patch from Andrew Gaul that plugs a leak:
Ka-Hing Cheung <khc@hxbc.us>
parents: 21013
diff changeset
167 purple_url_parse(url, &webaddress, NULL, &webpage, NULL, NULL);
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
168 request = g_strdup_printf("GET %s%s/%s HTTP/1.1\r\n"
25622
e4d738813cd8 Backport the parts of b859960a4a19f57f20db0536c1815a6d79e08e36 that apply to
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 24669
diff changeset
169 "User-Agent: " YAHOO_CLIENT_USERAGENT "\r\n"
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
170 "Cookie: T=%s; Y=%s\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
171 "Host: %s\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
172 "Cache-Control: no-cache\r\n\r\n",
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
173 use_whole_url ? "http://" : "", use_whole_url ? webaddress : "", webpage,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
174 yd->cookie_t, yd->cookie_y,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
175 webaddress);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
176
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
177 /* We have a URL and some header information, let's connect and get some aliases */
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
178 url_data = purple_util_fetch_url_request(url, use_whole_url, NULL, TRUE,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
179 request, FALSE,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
180 yahoo_fetch_aliases_cb, cb);
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
181 if (url_data != NULL)
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
182 yd->url_datas = g_slist_prepend(yd->url_datas, url_data);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
183
21016
abd768f06e7b Another patch from Andrew Gaul that plugs a leak:
Ka-Hing Cheung <khc@hxbc.us>
parents: 21013
diff changeset
184 g_free(webaddress);
abd768f06e7b Another patch from Andrew Gaul that plugs a leak:
Ka-Hing Cheung <khc@hxbc.us>
parents: 21013
diff changeset
185 g_free(webpage);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
186 g_free(request);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
187 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
188
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
189 /**************************************************************************
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
190 * Alias Update Functions
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
191 **************************************************************************/
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
192
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
193 static void
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
194 yahoo_update_alias_cb(PurpleUtilFetchUrlData *url_data, gpointer user_data, const gchar *url_text, size_t len, const gchar *error_message)
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
195 {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
196 xmlnode *node, *result;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
197 struct callback_data *cb = user_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
198 PurpleConnection *gc = cb->gc;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
199 struct yahoo_data *yd;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
200
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
201 yd = gc->proto_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
202 yd->url_datas = g_slist_remove(yd->url_datas, url_data);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
203
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
204 if (len == 0 || error_message != NULL) {
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
205 purple_debug_info("yahoo", "Error updating alias for %s: %s\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
206 cb->who,
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
207 error_message ? error_message : "");
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
208 g_free(cb->who);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
209 g_free(cb->id);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
210 g_free(cb);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
211 return;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
212 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
213
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
214 result = xmlnode_from_str(url_text, -1);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
215
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
216 if (result == NULL) {
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
217 purple_debug_error("yahoo", "Alias update for %s failed: Badly formed response\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
218 cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
219 g_free(cb->who);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
220 g_free(cb->id);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
221 g_free(cb);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
222 return;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
223 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
224
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
225 if ((node = xmlnode_get_child(result, "ct"))) {
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
226 if (cb->id == NULL) {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
227 const char *new_id = xmlnode_get_attrib(node, "id");
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
228 if (new_id != NULL) {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
229 /* We now have an addressbook id for the friend; we should save it */
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
230 YahooFriend *f = yahoo_friend_find(cb->gc, cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
231
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
232 purple_debug_info("yahoo", "Alias creation for %s succeeded\n", cb->who);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
233
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
234 if (f)
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
235 yahoo_friend_set_alias_id(f, new_id);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
236 else
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
237 purple_debug_error("yahoo", "Missing YahooFriend. Unable to store new addressbook id.\n");
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
238 } else
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
239 purple_debug_error("yahoo", "Missing new addressbook id in add response for %s (weird).\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
240 cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
241 } else {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
242 if (g_ascii_strncasecmp(xmlnode_get_attrib(node, "id"), cb->id, strlen(cb->id))==0)
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
243 purple_debug_info("yahoo", "Alias update for %s succeeded\n", cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
244 else
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
245 purple_debug_error("yahoo", "Alias update for %s failed (Contact record return mismatch)\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
246 cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
247 }
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
248 } else
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
249 purple_debug_info("yahoo", "Alias update for %s failed (No contact record returned)\n", cb->who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
250
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
251 g_free(cb->who);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
252 g_free(cb->id);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
253 g_free(cb);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
254 xmlnode_free(result);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
255 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
256
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
257 void
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
258 yahoo_update_alias(PurpleConnection *gc, const char *who, const char *alias)
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
259 {
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
260 struct yahoo_data *yd;
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
261 const char *url;
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
262 gchar *content, *request, *webpage, *webaddress;
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
263 struct callback_data *cb;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
264 PurpleUtilFetchUrlData *url_data;
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
265 YahooFriend *f;
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
266 /* use whole URL if using HTTP Proxy */
23986
18a1f0fe5f40 Do a better job of detecting if the yahoo account is connecting through a HTTP
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23017
diff changeset
267 gboolean use_whole_url = yahoo_account_use_http_proxy(gc);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
268
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
269 g_return_if_fail(who != NULL);
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
270 g_return_if_fail(gc != NULL);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
271
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
272 if (alias == NULL)
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
273 alias = "";
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
274
22831
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
275 f = yahoo_friend_find(gc, who);
0b11895cc564 Leak fixes. Avoid creating an unnecessary parallel data structure to YahooFriend.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22818
diff changeset
276 if (f == NULL) {
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
277 purple_debug_error("yahoo", "Missing YahooFriend. Unable to set server alias.\n");
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
278 return;
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
279 }
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
280
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
281 yd = gc->proto_data;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
282
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
283 /* Using callback_data so I have access to gc in the callback function */
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
284 cb = g_new0(struct callback_data, 1);
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
285 cb->who = g_strdup(who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
286 cb->id = g_strdup(yahoo_friend_get_alias_id(f));
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
287 cb->gc = gc;
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
288
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
289 /* Build all the info to make the web request */
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
290 url = yd->jp ? YAHOOJP_ALIAS_UPDATE_URL: YAHOO_ALIAS_UPDATE_URL;
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
291 purple_url_parse(url, &webaddress, NULL, &webpage, NULL, NULL);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
292
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
293 if (cb->id == NULL) {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
294 /* No id for this buddy, so create an address book entry */
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
295 purple_debug_info("yahoo", "Creating '%s' as new alias for user '%s'\n", alias, who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
296
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
297 if (yd->jp) {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
298 gchar *alias_jp = g_convert(alias, -1, "EUC-JP", "UTF-8", NULL, NULL, NULL);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
299 gchar *converted_alias_jp = yahoo_convert_to_numeric(alias_jp);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
300 content = g_strdup_printf("<ab k=\"%s\" cc=\"9\">\n"
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
301 "<ct a=\"1\" yi='%s' nn='%s' />\n</ab>\r\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
302 purple_account_get_username(gc->account),
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
303 who, converted_alias_jp);
24669
c0226e400836 Use g_free instead of free here too.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents: 23986
diff changeset
304 g_free(converted_alias_jp);
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
305 g_free(alias_jp);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
306 } else {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
307 gchar *escaped_alias = g_markup_escape_text(alias, -1);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
308 content = g_strdup_printf("<?xml version=\"1.0\" encoding=\"utf-8\"?><ab k=\"%s\" cc=\"9\">\n"
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
309 "<ct a=\"1\" yi='%s' nn='%s' />\n</ab>\r\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
310 purple_account_get_username(gc->account),
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
311 who, escaped_alias);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
312 g_free(escaped_alias);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
313 }
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
314 } else {
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
315 purple_debug_info("yahoo", "Updating '%s' as new alias for user '%s'\n", alias, who);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
316
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
317 if (yd->jp) {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
318 gchar *alias_jp = g_convert(alias, -1, "EUC-JP", "UTF-8", NULL, NULL, NULL);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
319 gchar *converted_alias_jp = yahoo_convert_to_numeric(alias_jp);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
320 content = g_strdup_printf("<ab k=\"%s\" cc=\"1\">\n"
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
321 "<ct e=\"1\" yi='%s' id='%s' nn='%s' pr='0' />\n</ab>\r\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
322 purple_account_get_username(gc->account),
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
323 who, cb->id, converted_alias_jp);
24669
c0226e400836 Use g_free instead of free here too.
Sadrul Habib Chowdhury <imadil@gmail.com>
parents: 23986
diff changeset
324 g_free(converted_alias_jp);
23017
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
325 g_free(alias_jp);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
326 } else {
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
327 gchar *escaped_alias = g_markup_escape_text(alias, -1);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
328 content = g_strdup_printf("<?xml version=\"1.0\" encoding=\"utf-8\"?><ab k=\"%s\" cc=\"1\">\n"
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
329 "<ct e=\"1\" yi='%s' id='%s' nn='%s' pr='0' />\n</ab>\r\n",
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
330 purple_account_get_username(gc->account),
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
331 who, cb->id, escaped_alias);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
332 g_free(escaped_alias);
adbcf5b84438 applied changes from 7a490c356e10f7fff3432f875897aa0ca0ad1ff0
Daniel Atallah <daniel.atallah@gmail.com>
parents: 23007
diff changeset
333 }
22115
4ab154a14e55 Patch from Yusuke Odate, modified by me, to support retrieving the full
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
334 }
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
335
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
336 request = g_strdup_printf("POST %s%s/%s HTTP/1.1\r\n"
25622
e4d738813cd8 Backport the parts of b859960a4a19f57f20db0536c1815a6d79e08e36 that apply to
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 24669
diff changeset
337 "User-Agent: " YAHOO_CLIENT_USERAGENT "\r\n"
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
338 "Cookie: T=%s; Y=%s\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
339 "Host: %s\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
340 "Content-Length: %" G_GSIZE_FORMAT "\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
341 "Cache-Control: no-cache\r\n\r\n"
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
342 "%s",
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
343 use_whole_url ? "http://" : "", use_whole_url ? webaddress : "", webpage,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
344 yd->cookie_t, yd->cookie_y,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
345 webaddress,
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
346 strlen(content),
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
347 content);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
348
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
349 /* We have a URL and some header information, let's connect and update the alias */
22056
b0ed2ce8514d A patch from Gideon N. Guillen, with some minor modifications from me. This
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 21284
diff changeset
350 url_data = purple_util_fetch_url_request(url, use_whole_url, NULL, TRUE, request, FALSE, yahoo_update_alias_cb, cb);
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
351 if (url_data != NULL)
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
352 yd->url_datas = g_slist_prepend(yd->url_datas, url_data);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
353
23007
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
354 g_free(webpage);
318905da6f8d Fix a printf("%s", NULL) situation and plug some leakage. Fixes #5280.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 22831
diff changeset
355 g_free(webaddress);
21013
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
356 g_free(content);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
357 g_free(request);
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
358 }
32e3d45aa1b2 Fix a crash that occurs when the HTTP call to set/get yahoo aliases fails. When purple_util_fetch_url_request() returns NULL, it has already triggered the callback. Fixes #3668.
Daniel Atallah <daniel.atallah@gmail.com>
parents: 20336
diff changeset
359