comparison src/signals.h @ 10789:0caa9827edf5

[gaim-migrate @ 12431] " The following log snippets should explain it: " --rlaager (20:24:00) rlaager: Regarding the signal handling conversation the other day... I've written a patch to stop calling signal handlers and return as soon as we find one signal handler that returns TRUE to indicate that it's handled the signal. Is this the right approach? (20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's documented to behave exactly the way it does (20:24:31) Ethan Blanton (Paco-Paco): so changing it is notbackwards compatible (20:24:31) rlaager: I'm talking for HEAD. (20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a good approach, yes (20:24:53) rlaager: The way I've described is how I *expected* it to work, having not read the documentation. (20:25:09) Ethan Blanton (Paco-Paco): I'm convinced (20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I assume, breaks the generic-ness of signals, by assuming that any that return values return booleans? (20:27:26) Ethan Blanton (Paco-Paco): please break it (20:27:33) Ethan Blanton (Paco-Paco): we already have out-parameters (20:27:42) rlaager: nosnilmot: from what I can see, the return type is handled as a (void *)... so I'm checking that ret_value != NULL (20:27:57) rlaager: nosnilmot: that's the correct way to do it, right? ... (20:29:01) Ethan Blanton (Paco-Paco): allowing a meaningful return value is an over-engineering (20:30:07) rlaager: even after this patch, you should be able to return meaningful return values (20:30:15) rlaager: it'll just short-circuit on the first handler that does committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Thu, 07 Apr 2005 14:55:02 +0000
parents 9b223bf37ca0
children e4459e8ccfb5
comparison
equal deleted inserted replaced
10788:19de830330cf 10789:0caa9827edf5
224 * @see gaim_signal_disconnect() 224 * @see gaim_signal_disconnect()
225 */ 225 */
226 void gaim_signal_emit_vargs(void *instance, const char *signal, va_list args); 226 void gaim_signal_emit_vargs(void *instance, const char *signal, va_list args);
227 227
228 /** 228 /**
229 * Emits a signal and returns the return value from the last handler. 229 * Emits a signal and returns the first non-NULL return value.
230 *
231 * Further signal handlers are NOT called after a handler returns
232 * something other than NULL.
230 * 233 *
231 * @param instance The instance emitting the signal. 234 * @param instance The instance emitting the signal.
232 * @param signal The signal being emitted. 235 * @param signal The signal being emitted.
233 * 236 *
234 * @return The return value from the last handler. 237 * @return The first non-NULL return value
235 */ 238 */
236 void *gaim_signal_emit_return_1(void *instance, const char *signal, ...); 239 void *gaim_signal_emit_return_1(void *instance, const char *signal, ...);
237 240
238 /** 241 /**
239 * Emits a signal and returns the return value from the last handler. 242 * Emits a signal and returns the first non-NULL return value.
243 *
244 * Further signal handlers are NOT called after a handler returns
245 * something other than NULL.
240 * 246 *
241 * @param instance The instance emitting the signal. 247 * @param instance The instance emitting the signal.
242 * @param signal The signal being emitted. 248 * @param signal The signal being emitted.
243 * @param args The arguments list. 249 * @param args The arguments list.
244 * 250 *
245 * @return The return value from the last handler. 251 * @return The first non-NULL return value
246 */ 252 */
247 void *gaim_signal_emit_vargs_return_1(void *instance, const char *signal, 253 void *gaim_signal_emit_vargs_return_1(void *instance, const char *signal,
248 va_list args); 254 va_list args);
249 255
250 /** 256 /**