Mercurial > pidgin

comparison src/protocols/oscar/auth.c @ 12429:59207955adc2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 14736] There are quite a few cases of empty if blocks for various aim_tlv_gettlv() calls. These calls exist in the code as documentation of various TLVs seen in the wild, but unhandled in Gaim for whatever reason. I'm changing them so the compiler is happy. This way, we can get quite a few useful warnings by turning on -Wextra. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Fri, 09 Dec 2005 04:05:04 +0000
parents 1d4a05772625
children
comparison
equal deleted inserted replaced
12428:9a0a6e74aafd 12429:59207955adc2
385 info->latestbeta.url = aim_tlv_getstr(tlvlist, 0x0041, 1); 385 info->latestbeta.url = aim_tlv_getstr(tlvlist, 0x0041, 1);
386 if (aim_tlv_gettlv(tlvlist, 0x0042, 1)) 386 if (aim_tlv_gettlv(tlvlist, 0x0042, 1))
387 info->latestbeta.info = aim_tlv_getstr(tlvlist, 0x0042, 1); 387 info->latestbeta.info = aim_tlv_getstr(tlvlist, 0x0042, 1);
388 if (aim_tlv_gettlv(tlvlist, 0x0043, 1)) 388 if (aim_tlv_gettlv(tlvlist, 0x0043, 1))
389 info->latestbeta.name = aim_tlv_getstr(tlvlist, 0x0043, 1); 389 info->latestbeta.name = aim_tlv_getstr(tlvlist, 0x0043, 1);
390 if (aim_tlv_gettlv(tlvlist, 0x0048, 1)) 390
391 ; /* beta serial */ 391 #if 0
392 if (aim_tlv_gettlv(tlvlist, 0x0048, 1)) {
393 /* beta serial */
394 }
395 #endif
392 396
393 if (aim_tlv_gettlv(tlvlist, 0x0044, 1)) 397 if (aim_tlv_gettlv(tlvlist, 0x0044, 1))
394 info->latestrelease.build = aim_tlv_get32(tlvlist, 0x0044, 1); 398 info->latestrelease.build = aim_tlv_get32(tlvlist, 0x0044, 1);
395 if (aim_tlv_gettlv(tlvlist, 0x0045, 1)) 399 if (aim_tlv_gettlv(tlvlist, 0x0045, 1))
396 info->latestrelease.url = aim_tlv_getstr(tlvlist, 0x0045, 1); 400 info->latestrelease.url = aim_tlv_getstr(tlvlist, 0x0045, 1);
397 if (aim_tlv_gettlv(tlvlist, 0x0046, 1)) 401 if (aim_tlv_gettlv(tlvlist, 0x0046, 1))
398 info->latestrelease.info = aim_tlv_getstr(tlvlist, 0x0046, 1); 402 info->latestrelease.info = aim_tlv_getstr(tlvlist, 0x0046, 1);
399 if (aim_tlv_gettlv(tlvlist, 0x0047, 1)) 403 if (aim_tlv_gettlv(tlvlist, 0x0047, 1))
400 info->latestrelease.name = aim_tlv_getstr(tlvlist, 0x0047, 1); 404 info->latestrelease.name = aim_tlv_getstr(tlvlist, 0x0047, 1);
401 if (aim_tlv_gettlv(tlvlist, 0x0049, 1)) 405
402 ; /* lastest release serial */ 406 #if 0
407 if (aim_tlv_gettlv(tlvlist, 0x0049, 1)) {
408 /* lastest release serial */
409 }
410 #endif
403 411
404 /* 412 /*
405 * URL to change password. 413 * URL to change password.
406 */ 414 */
407 if (aim_tlv_gettlv(tlvlist, 0x0054, 1)) 415 if (aim_tlv_gettlv(tlvlist, 0x0054, 1))
408 info->chpassurl = aim_tlv_getstr(tlvlist, 0x0054, 1); 416 info->chpassurl = aim_tlv_getstr(tlvlist, 0x0054, 1);
409 417
418 #if 0
410 /* 419 /*
411 * Unknown. Seen on an @mac.com screen name with value of 0x003f 420 * Unknown. Seen on an @mac.com screen name with value of 0x003f
412 */ 421 */
413 if (aim_tlv_gettlv(tlvlist, 0x0055, 1)) 422 if (aim_tlv_gettlv(tlvlist, 0x0055, 1)) {
414 ; 423 /* Unhandled */
424 }
425 #endif
415 426
416 sess->authinfo = info; 427 sess->authinfo = info;
417 428
418 if ((userfunc = aim_callhandler(sess, rx->conn, snac ? snac->family : 0x0017, snac ? snac->subtype : 0x0003))) 429 if ((userfunc = aim_callhandler(sess, rx->conn, snac ? snac->family : 0x0017, snac ? snac->subtype : 0x0003)))
419 ret = userfunc(sess, rx, info); 430 ret = userfunc(sess, rx, info);