Mercurial > pidgin
diff src/protocols/oscar/auth.c @ 12429:59207955adc2
[gaim-migrate @ 14736]
There are quite a few cases of empty if blocks for various aim_tlv_gettlv() calls. These calls exist in the code as documentation of various TLVs seen in the wild, but unhandled in Gaim for whatever reason. I'm changing them so the compiler is happy. This way, we can get quite a few useful warnings by turning on -Wextra.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Fri, 09 Dec 2005 04:05:04 +0000 |
| parents | 1d4a05772625 |
| children |
line wrap: on
line diff
--- a/src/protocols/oscar/auth.c Fri Dec 09 03:42:47 2005 +0000 +++ b/src/protocols/oscar/auth.c Fri Dec 09 04:05:04 2005 +0000 @@ -387,8 +387,12 @@ info->latestbeta.info = aim_tlv_getstr(tlvlist, 0x0042, 1); if (aim_tlv_gettlv(tlvlist, 0x0043, 1)) info->latestbeta.name = aim_tlv_getstr(tlvlist, 0x0043, 1); - if (aim_tlv_gettlv(tlvlist, 0x0048, 1)) - ; /* beta serial */ + +#if 0 + if (aim_tlv_gettlv(tlvlist, 0x0048, 1)) { + /* beta serial */ + } +#endif if (aim_tlv_gettlv(tlvlist, 0x0044, 1)) info->latestrelease.build = aim_tlv_get32(tlvlist, 0x0044, 1); @@ -398,8 +402,12 @@ info->latestrelease.info = aim_tlv_getstr(tlvlist, 0x0046, 1); if (aim_tlv_gettlv(tlvlist, 0x0047, 1)) info->latestrelease.name = aim_tlv_getstr(tlvlist, 0x0047, 1); - if (aim_tlv_gettlv(tlvlist, 0x0049, 1)) - ; /* lastest release serial */ + +#if 0 + if (aim_tlv_gettlv(tlvlist, 0x0049, 1)) { + /* lastest release serial */ + } +#endif /* * URL to change password. @@ -407,11 +415,14 @@ if (aim_tlv_gettlv(tlvlist, 0x0054, 1)) info->chpassurl = aim_tlv_getstr(tlvlist, 0x0054, 1); +#if 0 /* * Unknown. Seen on an @mac.com screen name with value of 0x003f */ - if (aim_tlv_gettlv(tlvlist, 0x0055, 1)) - ; + if (aim_tlv_gettlv(tlvlist, 0x0055, 1)) { + /* Unhandled */ + } +#endif sess->authinfo = info;