Mercurial > pidgin
comparison libpurple/protocols/oscar/encoding.h @ 30385:9d386bf63eab
Stop using custom encodings (and LATIN-1, for that matter) for sending
OSCAR messages (ICBM, chat, Direct IM). Now, we use ASCII if a message
contains ASCII characters only, and UTF-16 in all other cases.
That fixes #10833 (offline messages now will be sent as UTF-16)
and also a whole bunch of potential problems we can get
with charset 0x3. Different clients tend to interpret this
charset differently; for instance, the official client
always interprets it as LATIN-1, while alternative
clients may decode it as some other user-specified
8-bit encoding. On the other hand, ASCII messages
(charset 0x0) and UTF-16 messages (charset 0x2) are understood
uniformly by all clients.
I also cleaned-up the code a little (got rid of code paths that were
never executed, flags that were always set, unused struct members, etc.)
author | ivan.komarov@soc.pidgin.im |
---|---|
date | Tue, 27 Jul 2010 21:17:01 +0000 |
parents | 42862490dcb7 |
children | ca90b6c27eb8 |
comparison
equal
deleted
inserted
replaced
30384:42862490dcb7 | 30385:9d386bf63eab |
---|---|
25 #include "oscarcommon.h" | 25 #include "oscarcommon.h" |
26 | 26 |
27 /** | 27 /** |
28 * Determine the simplest encoding we can send this message in. | 28 * Determine the simplest encoding we can send this message in. |
29 */ | 29 */ |
30 guint32 oscar_charset_check(const char *utf8); | 30 guint16 oscar_charset_check(const char *utf8); |
31 | 31 |
32 /** | 32 /** |
33 * Take a string of the form charset="bleh" where bleh is | 33 * Take a string of the form charset="bleh" where bleh is |
34 * one of us-ascii, utf-8, iso-8859-1, or unicode-2-0, and | 34 * one of us-ascii, utf-8, iso-8859-1, or unicode-2-0, and |
35 * return a newly allocated string containing bleh. | 35 * return a newly allocated string containing bleh. |
54 const gchar *data, gsize datalen); | 54 const gchar *data, gsize datalen); |
55 | 55 |
56 /** | 56 /** |
57 * Figure out what encoding to use when sending a given outgoing message. | 57 * Figure out what encoding to use when sending a given outgoing message. |
58 */ | 58 */ |
59 void oscar_convert_to_best_encoding(PurpleConnection *gc, | 59 gchar * oscar_convert_to_best_encoding(const gchar *msg, gsize *result_len, guint16 *charset, gchar **charsetstr); |
60 const char *destbn, const gchar *from, | |
61 gchar **msg, int *msglen_int, | |
62 guint16 *charset, guint16 *charsubset); | |
63 | 60 |
64 #endif | 61 #endif |