diff libpurple/protocols/oscar/encoding.h @ 30385:9d386bf63eab

Stop using custom encodings (and LATIN-1, for that matter) for sending OSCAR messages (ICBM, chat, Direct IM). Now, we use ASCII if a message contains ASCII characters only, and UTF-16 in all other cases. That fixes #10833 (offline messages now will be sent as UTF-16) and also a whole bunch of potential problems we can get with charset 0x3. Different clients tend to interpret this charset differently; for instance, the official client always interprets it as LATIN-1, while alternative clients may decode it as some other user-specified 8-bit encoding. On the other hand, ASCII messages (charset 0x0) and UTF-16 messages (charset 0x2) are understood uniformly by all clients. I also cleaned-up the code a little (got rid of code paths that were never executed, flags that were always set, unused struct members, etc.)

--- a/libpurple/protocols/oscar/encoding.h	Mon Jul 26 17:02:32 2010 +0000
+++ b/libpurple/protocols/oscar/encoding.h	Tue Jul 27 21:17:01 2010 +0000
@@ -27,7 +27,7 @@
 /**
  * Determine the simplest encoding we can send this message in.
  */
-guint32 oscar_charset_check(const char *utf8);
+guint16 oscar_charset_check(const char *utf8);
 
 /**
  * Take a string of the form charset="bleh" where bleh is
@@ -56,9 +56,6 @@
 /**
  * Figure out what encoding to use when sending a given outgoing message.
  */
-void oscar_convert_to_best_encoding(PurpleConnection *gc,
-				const char *destbn, const gchar *from,
-				gchar **msg, int *msglen_int,
-				guint16 *charset, guint16 *charsubset);
+gchar * oscar_convert_to_best_encoding(const gchar *msg, gsize *result_len, guint16 *charset, gchar **charsetstr);
 
 #endif
\ No newline at end of file