view finch/gntroomlist.h @ 24065:85bed17fe5c1

The variable we use to keep track of the watcher of the ssl connection should be unsigned. This isn't really a problem in Pidgin, where we use glib's mainloop and GIOChannels because glib starts assigning the handle IDs sequentially starting from 1. But if an eventloop implementation ever returns a handle ID greater than the largest possible signed integer (2,147,483,647) then we won't be able to remove the watcher because purple_ssl_close() in sslconn.c only removes it if inpa > 0, and since it interprets inpa as a signed value then handles over 2,147,483,647 appear as negative numbers. I stumbled upon this when playing around with libevent, which can use epoll. My implementation generated a random handle ID which was sometimes greater than 2,147,483,647. I don't believe this breaks binary compatibility. And I don't think it breaks source compatibility, but I guess it might depend on what compiler you're using.

/**
 * @file gntroomlist.h GNT Room List API
 * @ingroup finch
 */

/* finch
 *
 * Finch is the legal property of its developers, whose names are too numerous
 * to list here.  Please refer to the COPYRIGHT file distributed with this
 * source distribution.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02111-1301  USA
 */
#ifndef _GNT_ROOMLIST_H
#define _GNT_ROOMLIST_H

#include "roomlist.h"

/**********************************************************************
 * @name GNT Room List API
 **********************************************************************/
/*@{*/

/**
 * Initialize the roomlist subsystem.
 */
void finch_roomlist_init(void);

/**
 * Get the ui-functions.
 *
 * @return The PurpleRoomlistUiOps structure populated with the appropriate functions.
 */
PurpleRoomlistUiOps *finch_roomlist_get_ui_ops(void);

/**
 * Show the roomlist dialog.
 */
void finch_roomlist_show_all(void);

/**
 * Uninitialize the roomlist subsystem.
 */
void finch_roomlist_uninit(void);

/*@}*/

#endif