Mercurial > pidgin
changeset 24065:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Thu, 04 Sep 2008 18:04:29 +0000 |
| parents | a0381a68ceef |
| children | 5a96b250b36d |
| files | libpurple/sslconn.h |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/libpurple/sslconn.h Thu Sep 04 04:05:54 2008 +0000 +++ b/libpurple/sslconn.h Thu Sep 04 18:04:29 2008 +0000 @@ -67,7 +67,7 @@ int fd; /** Glib event source ID; used to refer to the received data callback * in the glib eventloop */ - int inpa; + guint inpa; /** Data related to the underlying TCP connection */ PurpleProxyConnectData *connect_data;