Mercurial > pidgin
view PROGRAMMING_NOTES @ 14278:f71894e1700d
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 21 Aug 2006 22:50:58 +0000 |
parents | da88e2cd5c53 |
children | 83ec0b408926 |
line wrap: on
line source
Notes on keeping GAIM OS independant ------------------------------------ General ------- - Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths - Use g_getenv, g_snprintf, g_vsnprintf - Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME") - Make sure when including win32dep.h that it is the last header to be included. - Open binary files when reading or writing with 'b' mode. e.g: fopen("somefile", "wb"); Not doing so will open files in windows using defaut translation mode. i.e. newline -> <CR><LF> Paths ----- - DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions. Doing the following will therefore break the windows build: printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png"); it should be: printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png"); PLUGINS & PROTOS ---------------- - G_MODULE_EXPORT all functions which are to be accessed from outside the scope of its "dll" or "so". (E.G. gaim_plugin_init) - G_MODULE_IMPORT all global variables which are located outside your dynamic library. (E.G. connections) (Not doing this will cause "Memory Access Violations" in Win32)