Mercurial > pidgin
changeset 14278:f71894e1700d
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
committer: Tailor Script <tailor@pidgin.im>
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Mon, 21 Aug 2006 22:50:58 +0000 |
| parents | 06f03f2bc6c6 |
| children | c590ec448bc3 |
| files | libgaim/protocols/msn/switchboard.c |
| diffstat | 1 files changed, 1 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/libgaim/protocols/msn/switchboard.c Mon Aug 21 22:48:19 2006 +0000 +++ b/libgaim/protocols/msn/switchboard.c Mon Aug 21 22:50:58 2006 +0000 @@ -252,8 +252,7 @@ gaim_conversation_destroy(swboard->conv); #endif - cmdproc->session->conv_seq++; - swboard->chat_id = cmdproc->session->conv_seq; + swboard->chat_id = cmdproc->session->conv_seq++; swboard->flag |= MSN_SB_FLAG_IM; swboard->conv = serv_got_joined_chat(account->gc, swboard->chat_id,