Mercurial > pidgin
changeset 24386:6e4979001d6d
The "processing" flag basically says "this connection is busy, don't
destroy it yet, wait until it's done processing."
I don't think there's any reason for us to set processing to TRUE just
because we're connecting. I think this is a holdover from before our
purple_proxy_connect() could be canceled. But now that it's cancelable,
if we want to kill the connection we can cleanly cancel the connect
without worrying about the callback being triggered.
| author | Mark Doliner <mark@kingant.net> |
|---|---|
| date | Wed, 12 Nov 2008 09:10:29 +0000 |
| parents | 5b5c21b60690 |
| children | 3520b566ce25 |
| files | libpurple/protocols/msn/servconn.c |
| diffstat | 1 files changed, 1 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/libpurple/protocols/msn/servconn.c Wed Nov 12 08:58:27 2008 +0000 +++ b/libpurple/protocols/msn/servconn.c Wed Nov 12 09:10:29 2008 +0000 @@ -239,15 +239,7 @@ servconn->connect_data = purple_proxy_connect(NULL, session->account, host, port, connect_cb, servconn); - if (servconn->connect_data != NULL) - { - servconn->processing = TRUE; - return TRUE; - } - else - { - return FALSE; - } + return (servconn->connect_data != NULL); } void