changeset 22841:b77d000b738b

Add a comment. Could someone familiar with the Jabber protocol or our Jabber PRPL comment on this (or change my comment to an explanatory one?) Etan? Nathan? Thanks!
author Mark Doliner <mark@kingant.net>
date Sun, 04 May 2008 20:44:08 +0000
parents 04e0d8677b9a
children 7b21c5b208fb
files libpurple/protocols/jabber/roster.c
diffstat 1 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/jabber/roster.c	Sun May 04 04:15:11 2008 +0000
+++ b/libpurple/protocols/jabber/roster.c	Sun May 04 20:44:08 2008 +0000
@@ -329,6 +329,14 @@
 
 	jb = jabber_buddy_find(js, buddy->name, FALSE);
 
+	/*
+	 * For some reason if we're waiting for our subscription request
+	 * to be approved and we try to add the buddy to another group
+	 * then we remove the buddy from the old group.  I don't understand
+	 * the rationale for this, can someone please explain it?  It seems
+	 * like we should pass NULL as the groups parameter to
+	 * jabber_roster_update().
+	 */
 	if(!jb || !(jb->subscription & JABBER_SUB_TO)) {
 		groups = g_slist_append(groups, group->name);
 	}