changeset 31802:c2a7fde6a566

Fix potential crash when NAMES is empty. Fixes #14518 committer: Ethan Blanton <elb@pidgin.im>
author jamie@lacewing-project.org
date Tue, 16 Aug 2011 17:11:39 +0000
parents 65fc614f11e4
children dc30c2bcc299
files COPYRIGHT ChangeLog libpurple/protocols/irc/msgs.c
diffstat 3 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/COPYRIGHT	Tue Aug 16 15:08:57 2011 +0000
+++ b/COPYRIGHT	Tue Aug 16 17:11:39 2011 +0000
@@ -332,6 +332,7 @@
 Ryan McCabe
 Peter McCurdy
 Kurt McKee
+James McLaughlin
 Torrey McMahon
 Greg McNew
 Robert McQueen
--- a/ChangeLog	Tue Aug 16 15:08:57 2011 +0000
+++ b/ChangeLog	Tue Aug 16 17:11:39 2011 +0000
@@ -33,6 +33,7 @@
 	ICQ:
 	* Fix crash selecting Tools->Set Mood when you're online with an
 	  ICQ account that is configured as an AIM account. (#14437)
+	* Fix crash when NAMES is empty. (James McLaughlin) (#14518)
 
 	IRC:
 	* Fix the handling of formatting following mIRC ^O (#14436)
--- a/libpurple/protocols/irc/msgs.c	Tue Aug 16 15:08:57 2011 +0000
+++ b/libpurple/protocols/irc/msgs.c	Tue Aug 16 17:11:39 2011 +0000
@@ -587,7 +587,7 @@
 			else
 				purple_conv_im_write(PURPLE_CONV_IM(convo), "", msg, PURPLE_MESSAGE_SYSTEM|PURPLE_MESSAGE_NO_LOG, time(NULL));
 			g_free(msg);
-		} else {
+		} else if (cur != NULL) {
 			GList *users = NULL;
 			GList *flags = NULL;