changeset 17684:e440846f9a21

Increase password length limit to 10 and update changes file.
author Jeffrey Connelly <jaconnel@calpoly.edu>
date Wed, 04 Jul 2007 02:13:34 +0000
parents dbf7fe20799d
children ea5258b0f67d
files libpurple/protocols/myspace/CHANGES libpurple/protocols/myspace/myspace.c libpurple/protocols/myspace/myspace.h
diffstat 3 files changed, 11 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/myspace/CHANGES	Tue Jul 03 05:21:55 2007 +0000
+++ b/libpurple/protocols/myspace/CHANGES	Wed Jul 04 02:13:34 2007 +0000
@@ -1,6 +1,10 @@
 2007-07-xx Jeff Connelly <jeff2@soc.pidgin.im> - 0.10
-* On incoming instant messages, support: text color, font face.
+* On incoming instant messages, add support for:
+ * Text color
+ * Font face
 * Add option to sign on as hidden, default off (previously, always was hidden)
+* Add ability to change status to hidden, available, away
+* Increase password length limit to 10 to match official client
 
 2007-07-01 Jeff Connelly <jeff2@soc.pidgin.im> - 0.9
 * Fix crash on Windows when logging in (bug #1990)
--- a/libpurple/protocols/myspace/myspace.c	Tue Jul 03 05:21:55 2007 +0000
+++ b/libpurple/protocols/myspace/myspace.c	Wed Jul 04 02:13:34 2007 +0000
@@ -273,16 +273,12 @@
     gc = purple_account_get_connection(acct);
     gc->proto_data = msim_session_new(acct);
 
+    /* Passwords are limited in length. */
 	if (strlen(acct->password) > MSIM_MAX_PASSWORD_LENGTH)
 	{
 		gchar *str;
 
 
-		/* TODO: Find out why >8 is problematic. The web site lets you have
-		 * long passwords, but reportedly the official IM client does not
-		 * allow more than 8 characters to be entered. Just entering the first
-		 * 8 does not, on first try, appear to work. */
-		/* Note: official client lets you have 10 characters in password. */
 		str = g_strdup_printf(
 				_("Sorry, passwords over %d characters in length (yours is "
 				"%d) are currently not supported by the MySpaceIM plugin."), 
@@ -297,7 +293,6 @@
 		g_free(str);
 	}
 
-
     /* 1. connect to server */
     purple_connection_update_progress(gc, _("Connecting"),
                                   0,   /* which connection step this is */
--- a/libpurple/protocols/myspace/myspace.h	Tue Jul 03 05:21:55 2007 +0000
+++ b/libpurple/protocols/myspace/myspace.h	Wed Jul 04 02:13:34 2007 +0000
@@ -74,7 +74,11 @@
 
 /* Constants */
 
-#define MSIM_MAX_PASSWORD_LENGTH 	8
+/* Maximum length of a password that is acceptable. This is the limit
+ * on the official client (build 679) and on the 'new password' field at
+ * http://settings.myspace.com/index.cfm?fuseaction=user.changepassword
+ * (though curiously, not on the 'current password' field). */
+#define MSIM_MAX_PASSWORD_LENGTH 	10
 
 /* Build version of MySpaceIM to report to servers (1.0.xxx.0) */
 #define MSIM_CLIENT_VERSION     673