Mercurial > pidgin
changeset 12224:e84fbd0be612
[gaim-migrate @ 14526]
Bartosz Oler suggested this change to strtol() in ggp_str_to_uin(). I asked if it was really necessary...
(17:00:29) Bartosz Oler (liar): Hm. UINs are base 10 numbers. And it might be hard to trace a bug if user will accidentally type his number with a leading zero. I see no usecase for ggp_str_to_uin with octal numbers.
That seems reasonable to me. I cleaned up the documentation for this function a little.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Fri, 25 Nov 2005 17:22:54 +0000 |
| parents | 546c292b7f98 |
| children | 078f39bdf3d4 |
| files | src/protocols/gg/utils.c src/protocols/gg/utils.h |
| diffstat | 2 files changed, 7 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/src/protocols/gg/utils.c Fri Nov 25 16:38:07 2005 +0000 +++ b/src/protocols/gg/utils.c Fri Nov 25 17:22:54 2005 +0000 @@ -24,8 +24,8 @@ #include "utils.h" -/* static uin_t ggp_str_to_uin(const char *text) {{{ */ -uin_t ggp_str_to_uin(const char *text) +/* uin_t ggp_str_to_uin(const char *str) {{{ */ +uin_t ggp_str_to_uin(const char *str) { char *tmp; long num; @@ -34,7 +34,7 @@ return 0; errno = 0; - num = strtol(text, &tmp, 0); + num = strtol(text, &tmp, 10); if (*text == '\0' || *tmp != '\0') return 0;
--- a/src/protocols/gg/utils.h Fri Nov 25 16:38:07 2005 +0000 +++ b/src/protocols/gg/utils.h Fri Nov 25 17:22:54 2005 +0000 @@ -39,13 +39,13 @@ /* - * Convert string to number. Check wheter a given - * string is a correct UIN. + * Convert a base 10 string to a UIN. * - * Return UIN or 0 if an error occurred. + * @param str The string to convert + * @return UIN or 0 if an error occurred. */ uin_t -ggp_str_to_uin(const char *text); +ggp_str_to_uin(const char *str); /** * Convert enconding of a given string.