Mercurial > mplayer.hg
annotate DOCS/tech/svn-howto.txt @ 22511:6fb4b3944764
Clarify that commits should not be split arbitrarily by file/directory.
author | diego |
---|---|
date | Mon, 12 Mar 2007 17:38:32 +0000 |
parents | 76f7adafc67b |
children | 702085652768 |
rev | line source |
---|---|
2200 | 1 |
18660 | 2 About Subversion write access: |
3 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
2200 | 4 |
18705 | 5 Before everything else, you should know how to use Subversion properly. |
18840 | 6 Luckily Subversion comes with excellent documentation. |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
7 |
18705 | 8 svn help |
18840 | 9 |
10 shows you the available subcommands, | |
11 | |
12 svn help <command> | |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
13 |
18840 | 14 shows information about the subcommand <command>. |
15 | |
16 The most comprehensive manual is the book "Version Control with Subversion" | |
17 by Ben Collins-Sussman, Brian W. Fitzpatrick and C. Michael Pilato. It can | |
18 be viewed online at | |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
19 |
18705 | 20 http://svnbook.org/ |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
21 |
18705 | 22 For more information about the Subversion project, visit |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
23 |
18705 | 24 http://subversion.tigris.org/ |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
25 |
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
26 Consult these resources whenever you have problems, they are quite exhaustive. |
18840 | 27 |
28 What follows now is a basic introduction to Subversion and some MPlayer-specific | |
29 guidelines. Read it at least once, if you are granted commit privileges to the | |
30 MPlayer project you are expected to be familiar with these rules. | |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
31 |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
32 |
18841 | 33 |
18840 | 34 I. BASICS: |
35 ========== | |
36 | |
19248
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
37 0. Get Subversion: |
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
38 |
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
39 The MPlayer project server runs Subversion 1.2.3. For optimal compatibility |
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
40 you should use version 1.2.3 or later. |
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
41 |
dd30cb46819d
Add a paragraph about which Subversion version to use.
diego
parents:
18845
diff
changeset
|
42 |
18840 | 43 1. Checking out the source tree: |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
44 |
18840 | 45 svn checkout svn://svn.mplayerhq.hu/mplayer/trunk/ <target> |
2200 | 46 |
18840 | 47 This will put the MPlayer sources into the directory <target>. |
2200 | 48 |
18841 | 49 |
18840 | 50 2. Updating the source tree to the latest revision: |
18706 | 51 |
52 svn update | |
12024 | 53 |
18840 | 54 pulls in the latest changes from the repository to your working directory. |
55 | |
18841 | 56 |
18840 | 57 3. Adding/removing files/directories: |
58 | |
59 svn add <filename/dirname> | |
60 svn delete <filename/dirname> | |
61 | |
62 Subversion needs to get notified of all changes you make to your working | |
63 directory. | |
64 | |
18841 | 65 |
18840 | 66 4. Showing modifications: |
67 | |
68 svn diff <filename(s)> | |
69 | |
70 will show all local modifications in your working directory as unified diff. | |
71 | |
18841 | 72 |
18840 | 73 5. Inspecting the changelog: |
74 | |
75 svn log <filename(s)> | |
76 | |
77 You may also find viewvc, a web frontend for Subversion, helpful. It's often | |
78 more comfortable than using 'svn log' and 'svn diff'. Find it here: | |
79 http://svn.mplayerhq.hu/mplayer/trunk/ | |
80 | |
18841 | 81 |
18840 | 82 6. Checking source tree status: |
83 | |
84 svn status | |
85 | |
86 detects all the changes you made and lists what actions will be taken in case | |
87 of a commit (additions, modifications, deletions, etc.). | |
88 | |
18841 | 89 |
18840 | 90 7. Committing: |
2200 | 91 |
18767 | 92 svn update |
18840 | 93 |
94 Run 'svn update' before committing to make sure there were no changes to the | |
95 files you worked on in the meantime. Afterwards look at the output of | |
96 | |
97 svn diff <filename(s)> | |
12024 | 98 |
18840 | 99 to doublecheck your changes before committing to avoid trouble later on. All |
100 experienced developers do this on each and every commit, no matter how small. | |
101 Every one of them has been saved from looking like a fool by this many times. | |
102 It's very easy for stray debug output or cosmetic modifications to slip in, | |
103 please avoid problems through this extra level of scrutiny. | |
104 | |
19573
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
105 Also check the output of |
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
106 |
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
107 svn status |
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
108 |
19662 | 109 to make sure you did not forget to 'svn add' some files (they will be marked |
19573
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
110 with '?'). |
35d9fef1879e
svn diff does not show files you forgot to add, so recommend of svn status, too
reimar
parents:
19382
diff
changeset
|
111 |
18840 | 112 Once you have made sure everything is fine |
113 | |
114 svn commit <filename(s)> | |
115 | |
116 propagates your stuff to the repository. If you have made several independent | |
117 changes, commit them separately, not at the same time. | |
118 | |
119 When prompted for a password, type the password you got assigned by the | |
120 project admins. By default, Subversion caches all authentication tokens. | |
22510 | 121 This behavior can be disabled by setting both 'store-passwords' and |
18706 | 122 'store-auth-creds' to "no" in ~/.subversion/config. You might need to remove |
123 previous cache files, which are located in ~/.subversion/auth, by hand. | |
12024 | 124 |
18840 | 125 You will be prompted for a log message in an editor, which is either specified |
126 by --editor-cmd on the command line, set in your personal configuration file | |
127 (~/.subversion/config) or set by one of the following environment variables: | |
128 SVN_EDITOR, VISUAL or EDITOR. | |
12024 | 129 |
18840 | 130 Log messages should be concise but descriptive. Explain why you made a change, |
131 what you did will be obvious from the changes themselves most of the time. | |
132 Saying just "bug fix" or "10l" is bad. Remember that people of varying skill | |
133 levels look at and educate themselves while reading through your code. Don't | |
134 include filenames in log messages, Subversion provides that information. | |
18706 | 135 |
18841 | 136 |
19357
59af53f4f436
update the moving & copying rules as disscussed on mplayer-dev + some (but not all as iam lazy) fixes by the wanderer
michael
parents:
19248
diff
changeset
|
137 8. Renaming/moving/copying files or contents of files: |
13288 | 138 |
19376 | 139 svn move/copy <source> <destination> |
18840 | 140 svn commit <source> <destination> |
2200 | 141 |
19376 | 142 Do not move, rename or copy files of which you are not the maintainer without |
143 discussing it on the mplayer-dev-eng mailing list first! | |
19357
59af53f4f436
update the moving & copying rules as disscussed on mplayer-dev + some (but not all as iam lazy) fixes by the wanderer
michael
parents:
19248
diff
changeset
|
144 |
19376 | 145 Never copy or move a file by using 'svn delete' and 'svn add'. Always use |
146 'svn move' or 'svn copy' instead in order to preserve history and minimize | |
147 the size of diffs. | |
19357
59af53f4f436
update the moving & copying rules as disscussed on mplayer-dev + some (but not all as iam lazy) fixes by the wanderer
michael
parents:
19248
diff
changeset
|
148 |
19376 | 149 To split a file, use 'svn copy' and remove the unneeded lines from each file. |
2200 | 150 |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
151 Don't do a lot of cut'n'paste from one file to another without a very good |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
152 reason and discuss it on the mplayer-dev-eng mailing list first. It will make |
18840 | 153 those changes hard to trace. |
5415 | 154 |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
155 Such actions are useless and treated as cosmetics in 99% of cases, |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
156 so try to avoid them. |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
157 |
18841 | 158 |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
159 9. Reverting broken commits |
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
160 |
19382 | 161 There are 2 ways to reverse a change, they differ significantly in what they |
22510 | 162 do to the repository. |
19382 | 163 The recommit old method: |
164 svn merge | |
165 svn ci <file> | |
22510 | 166 This simply changes the file(s) back to their old version locally and then |
167 the change is committed as if it were a new change. | |
19382 | 168 The svn copy method |
169 svn rm <file> | |
170 svn ci <file> | |
171 svn cp -r<good revision> svn://svn.mplayerhq.hu/mplayer/trunk/[<path>/]<file> <file> | |
172 svn ci <file> | |
173 This simply removes the file and then copies the last good version with | |
22510 | 174 its history over it. This method can only be used to revert the n last |
175 commits but not to revert a bad commit in the middle of its history. | |
19382 | 176 Neither method will change the history, checking out an old version will |
177 always return exactly that revision with all its bugs and features. The | |
178 difference is that with the svn copy method the broken commit will not be | |
22238 | 179 part of the directly visible history of the revisions after the reversal |
180 So if the change was completely broken like reindenting a file against the | |
181 maintainers decision, or a change which mixed functional and cosmetic | |
22345 | 182 changes then it is better if it is not part of the visible history as it |
22510 | 183 would make it hard to read, review and would also break svn annotate. |
19382 | 184 For the example of a change which mixed functional and cosmetic parts they |
22238 | 185 should of course be committed again after the reversal but separately, so one |
22510 | 186 change with the functional stuff and one with the cosmetics. |
19382 | 187 OTOH if the change which you want to reverse was simply buggy but not |
188 totally broken then it should be reversed with svn merge as otherwise | |
22510 | 189 the fact that the change was bad would be hidden. |
19382 | 190 One method to decide which reversal method is best is to ask yourself |
22345 | 191 if there is any value in seeing the whole bad change and its removal |
22502 | 192 in SVN vs. just seeing a comment that says what has been reversed while |
22238 | 193 the actual change does not clutter the immediately visible history and |
19382 | 194 svn annotate. |
195 If you are even just slightly uncertain how to revert something then ask on | |
22345 | 196 the mplayer-dev-eng mailing list. |
15227
167085fd11af
'cvs admin -o' is dangerous and should be handled with extra care.
diego
parents:
14856
diff
changeset
|
197 |
18841 | 198 |
18840 | 199 10. Reverting local changes |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
200 |
18840 | 201 svn revert <filename(s)> |
14806
6abe4fb845ff
mphq uses ssh.com, explain RSA key generation for it.
diego
parents:
14059
diff
changeset
|
202 |
18706 | 203 In case you made a lot of local changes to a file and want to start over |
18840 | 204 with a fresh checkout of that file, you can use 'svn revert <filename(s)>'. |
18706 | 205 NOTE: This has nothing to do with reverting changes on the Subversion |
206 server! It only reverts changes that were not committed yet. If you need | |
207 to revert a broken commit, see 9. | |
11395
5484bc13e90a
Some notes about general CVS documentation added, new 'cvs admin' section
diego
parents:
9537
diff
changeset
|
208 |
18841 | 209 |
18840 | 210 11. Changing commit messages |
18764
5b89070daa50
add command for changing commit messages after the commit took place.
ivo
parents:
18706
diff
changeset
|
211 |
5b89070daa50
add command for changing commit messages after the commit took place.
ivo
parents:
18706
diff
changeset
|
212 svn propedit svn:log --revprop -r <revision> |
5b89070daa50
add command for changing commit messages after the commit took place.
ivo
parents:
18706
diff
changeset
|
213 |
5b89070daa50
add command for changing commit messages after the commit took place.
ivo
parents:
18706
diff
changeset
|
214 If your commit message is too short or not explanatory enough, you can edit |
18845 | 215 it afterwards with 'svn propedit'. |
18764
5b89070daa50
add command for changing commit messages after the commit took place.
ivo
parents:
18706
diff
changeset
|
216 |
18841 | 217 |
18840 | 218 Contact the project admins <root at mplayerhq dot hu> if you have technical |
18706 | 219 problems with the Subversion server. |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
220 |
2200 | 221 |
222 | |
223 II. POLICY / RULES: | |
224 =================== | |
225 | |
13288 | 226 1. You must not commit code which breaks MPlayer! (Meaning unfinished but |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
227 enabled code which breaks compilation or compiles but does not work.) |
13288 | 228 You can commit unfinished stuff (for testing etc), but it must be disabled |
229 (#ifdef etc) by default so it does not interfere with other developers' | |
230 work. | |
2200 | 231 |
18841 | 232 |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
233 2. You don't have to over-test things. If it works for you, and you think it |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
234 should work for others, too, then commit. If your code has problems |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
235 (portability, exploits compiler bugs, unusual environment etc) they will be |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
236 reported and eventually fixed. |
2200 | 237 |
18841 | 238 |
13288 | 239 3. Do not commit unrelated changes together, split them into self-contained |
22511
6fb4b3944764
Clarify that commits should not be split arbitrarily by file/directory.
diego
parents:
22510
diff
changeset
|
240 pieces, but not smaller. Do not split commits by files or directories, |
6fb4b3944764
Clarify that commits should not be split arbitrarily by file/directory.
diego
parents:
22510
diff
changeset
|
241 keep related changes together. |
2200 | 242 |
18841 | 243 |
17578 | 244 4. Do not change behavior of the program (renaming options etc) or |
17579
f1ce086b5eed
Clarify feature removal policy: it must be approved on the mailing list.
rathann
parents:
17578
diff
changeset
|
245 remove functionality from the code without approval in a discussion on |
f1ce086b5eed
Clarify feature removal policy: it must be approved on the mailing list.
rathann
parents:
17578
diff
changeset
|
246 the mplayer-dev-eng mailing list. |
12024 | 247 |
18841 | 248 |
13288 | 249 5. Do not commit changes to the build system (Makefiles, configure script) |
22510 | 250 which change behavior, defaults etc, without asking first. The same |
13288 | 251 applies to compiler warning fixes, trivial looking fixes and to code |
252 maintained by other developers. We usually have a reason for doing things | |
253 the way we do. Send your changes as patches to the mplayer-dev-eng mailing | |
254 list, and if the code maintainers say OK, you may commit. This does not | |
255 apply to files you wrote and/or maintain. | |
256 | |
18841 | 257 |
13288 | 258 6. We refuse source indentation and other cosmetic changes if they are mixed |
259 with functional changes, such commits will be rejected and removed. Every | |
260 developer has his own indentation style, you should not change it. Of course | |
261 if you (re)write something, you can use your own style... (Many projects | |
262 force a given indentation style - we don't.) If you really need to make | |
263 indentation changes (try to avoid this), separate them strictly from real | |
264 changes. | |
12024 | 265 |
266 NOTE: If you had to put if(){ .. } over a large (> 5 lines) chunk of code, | |
13288 | 267 do NOT change the indentation of the inner part (don't move it to the right)! |
2200 | 268 |
18841 | 269 |
13288 | 270 7. Always fill out the commit log message. Describe in a few lines what you |
271 changed and why. You can refer to mailing list postings if you fix a | |
272 particular bug. Comments such as "fixed!" or "Changed it." are unacceptable. | |
2200 | 273 |
18841 | 274 |
13288 | 275 8. If you apply a patch by someone else, include the name and email address in |
18660 | 276 the log message. Since the mplayer-cvslog mailing list is publicly |
13288 | 277 archived you should add some spam protection to the email address. Send an |
278 answer to mplayer-dev-eng (or wherever you got the patch from) saying that | |
17054 | 279 you applied the patch. If the patch contains a documentation change, commit |
280 that as well; do not leave it to the documentation maintainers. | |
2200 | 281 |
18841 | 282 |
13288 | 283 9. Do NOT commit to code actively maintained by others without permission. Send |
284 a patch to mplayer-dev-eng instead. | |
12107
bc89ddda34b8
Developers should subscribe to mplayer-cvslog, mention mplayer-docs.
diego
parents:
12099
diff
changeset
|
285 |
18841 | 286 |
18660 | 287 10. Subscribe to the mplayer-cvslog mailing list. The diffs of all commits |
12107
bc89ddda34b8
Developers should subscribe to mplayer-cvslog, mention mplayer-docs.
diego
parents:
12099
diff
changeset
|
288 are sent there and reviewed by all the other developers. Bugs and possible |
bc89ddda34b8
Developers should subscribe to mplayer-cvslog, mention mplayer-docs.
diego
parents:
12099
diff
changeset
|
289 improvements or general questions regarding commits are discussed there. We |
bc89ddda34b8
Developers should subscribe to mplayer-cvslog, mention mplayer-docs.
diego
parents:
12099
diff
changeset
|
290 expect you to react if problems with your code are uncovered. |
12024 | 291 |
18841 | 292 |
13288 | 293 11. Update the documentation if you change behavior or add features. If you are |
294 unsure how best to do this, send a patch to mplayer-docs, the documentation | |
295 maintainers will review and commit your stuff. | |
296 | |
18841 | 297 |
20783
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
298 12. Always send a patch to the mplayer-dev-eng mailing list before committing |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
299 if you suspect that the change is going to be controversial. Based on past |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
300 experience, these changes are likely to be controversial: |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
301 - feature removal, even if obsolete |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
302 - changes to "special" output messages (like the "Core dumped ;)" message) |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
303 - verbosity changes from default (info) level |
22510 | 304 - changes to "historical" parts of docs and web pages |
20783
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
305 - use of internal or external libraries |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
306 |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
307 |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
308 13. Try to keep important discussions and requests (also) on the |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
309 mplayer-dev-eng mailing list, so that all developers can benefit from them. |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
310 IRC is good for quick discussions, but nobody is there 24/7. |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
311 |
dc1a1ff6c7d9
Updated for controversial changes and irc-only decisions
rtogni
parents:
19662
diff
changeset
|
312 |
12099 | 313 Also read DOCS/tech/patches.txt !!!! |
5415 | 314 |
7904
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
315 We think our rules are not too hard. If you have comments, contact us. |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
316 |
98168d30f67d
Spellchecked, reworded, reformatted, small additions and corrections.
diego
parents:
5415
diff
changeset
|
317 |
3258 | 318 |
18827 | 319 III. Beginners Guide |
3258 | 320 ==================== |
18828 | 321 |
322 The typical flow of development would be: | |
323 | |
324 1. Check out the source: | |
325 | |
326 svn checkout svn://svn.mplayerhq.hu/mplayer/trunk/ devel | |
327 | |
18841 | 328 |
18828 | 329 2. Make your changes. |
330 | |
18841 | 331 |
18828 | 332 3. Create a patch: |
333 | |
18840 | 334 Run 'svn diff' from the root of the source tree, like this: |
18828 | 335 |
336 cd devel | |
337 svn diff > ../my_changes.patch | |
338 | |
339 If you have made several changes, but only want to submit one for review | |
340 by other developers, you can specify the filename(s), for example: | |
341 | |
342 svn diff mplayer.c > ../major_cleanup.patch | |
343 | |
18841 | 344 |
18828 | 345 4. Check the patch: |
346 | |
347 Check out another, clean source tree and verify your patch: | |
348 | |
349 svn checkout svn://svn.mplayerhq.hu/mplayer/trunk/ clean | |
350 cd clean | |
351 patch -p0 --dry-run < ../my_changes.patch | |
352 | |
353 If there are no errors, you can apply your patch: | |
354 | |
355 patch -p0 < ../my_changes.patch | |
356 | |
357 After that, verify that MPlayer still builds correctly with your patch | |
358 applied. Also, be sure that your patch meets our policy as described in | |
359 section II, specifically rules 1 to 6, before you continue submitting | |
360 the patch. | |
361 | |
18841 | 362 |
18828 | 363 5. Submit the patch: |
364 | |
365 Send an e-mail to the mplayer-dev-eng mailing list. Describe what your | |
366 patch does and why, and attach the patch file for review by others. | |
367 | |
18841 | 368 |
18828 | 369 6. During the review process, incorporate all suggested fixes. Go to step 2 |
370 repeatedly until there is nothing more to do for step 6. Of course, if | |
371 you don't agree with certain suggestions, things can be discussed on | |
372 the mailing list in a polite manner. | |
373 | |
18841 | 374 |
18828 | 375 7. Commit the patch: |
376 | |
377 If your patch is accepted, double check if your source tree contains the | |
18840 | 378 most recent version of your patch with 'svn diff'! After verifying that |
379 you met these conditions, commit with: | |
18828 | 380 |
18840 | 381 svn commit <filename(s)> |
18828 | 382 |
383 Go to step 2 ad infinitum until MPlayer is the perfect media player ;) | |
384 | |
18841 | 385 |
18828 | 386 Note: If you are listed as the maintainer for a particular piece of code, |
387 you can skip step 5 and 6 if your patch _only_ applies to the code you | |
388 maintain. If it touches other code or is otherwise very intrusive, please | |
389 post it to mplayer-dev-eng first. |