changeset 11602:24274a79d6b0

[gaim-migrate @ 13873] This _seems_ to be taking care of my infinite loop, thanks sadrul for suggesting it :) committer: Tailor Script <tailor@pidgin.im>
author Gary Kramlich <grim@reaperworld.com>
date Mon, 03 Oct 2005 21:49:02 +0000
parents 86501c7bce46
children b97545f21b4c
files src/conversation.c src/gtkconv.c
diffstat 2 files changed, 9 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/src/conversation.c	Mon Oct 03 21:33:33 2005 +0000
+++ b/src/conversation.c	Mon Oct 03 21:49:02 2005 +0000
@@ -341,15 +341,19 @@
 				gaim_prefs_get_bool("/core/logging/log_chats"));
 	}
 
-	ops  = conv->ui_ops = default_ops;
-	if (ops != NULL && ops->create_conversation != NULL)
-		ops->create_conversation(conv);
-
 	conversations = g_list_append(conversations, conv);
 
 	/* Auto-set the title. */
 	gaim_conversation_autoset_title(conv);
 
+	/* Don't move this.. it needs to be one of the last things done otherwise
+	 * it causes mysterious crashes on my system.
+	 *  -- Gary
+	 */
+	ops  = conv->ui_ops = default_ops;
+	if (ops != NULL && ops->create_conversation != NULL)
+		ops->create_conversation(conv);
+
 	gaim_signal_emit(gaim_conversations_get_handle(),
 					 "conversation-created", conv);
 
--- a/src/gtkconv.c	Mon Oct 03 21:33:33 2005 +0000
+++ b/src/gtkconv.c	Mon Oct 03 21:49:02 2005 +0000
@@ -1906,6 +1906,7 @@
 	if (gtk_check_menu_item_get_active((GtkCheckMenuItem*) m) == FALSE)
 		return;
 
+	/* I'm about 99.99% sure we're leaking a conversation here... */
 	conv = gaim_conversation_new(GAIM_CONV_TYPE_IM, account, name);
 	gtkconv = GAIM_GTK_CONVERSATION(conv);