changeset 23783:a5bfc59b0c6e

It turns out that setting the window title causes it to stop flashing on win32. This means that every time we recieve a typing notification event for the current tab, we lose notification that we have unread messages. Fortunately, we can avoid this by checking if we actually need to change the title. Fixes #1502 (yay!).
author Daniel Atallah <daniel.atallah@gmail.com>
date Thu, 14 Aug 2008 04:17:21 +0000
parents abf8ebd4c9e1
children d9d388a27d01
files pidgin/gtkconv.c
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkconv.c	Thu Aug 14 03:28:11 2008 +0000
+++ b/pidgin/gtkconv.c	Thu Aug 14 04:17:21 2008 +0000
@@ -6604,8 +6604,11 @@
 			update_typing_icon(gtkconv);
 
 		gtk_label_set_text(GTK_LABEL(gtkconv->menu_label), title);
-		if (pidgin_conv_window_is_active_conversation(conv))
-			gtk_window_set_title(GTK_WINDOW(win->window), title);
+		if (pidgin_conv_window_is_active_conversation(conv)) {
+			const char* current_title = gtk_window_get_title(GTK_WINDOW(win->window));
+			if (current_title == NULL || strcmp(current_title, title) != 0)
+				gtk_window_set_title(GTK_WINDOW(win->window), title);
+		}
 
 		g_free(title);
 	}